Skip to content

Overhaul tooling#63

Draft
RadekManak wants to merge 1 commit intoopenshift-eng:mainfrom
RadekManak:overhaul-tooling
Draft

Overhaul tooling#63
RadekManak wants to merge 1 commit intoopenshift-eng:mainfrom
RadekManak:overhaul-tooling

Conversation

@RadekManak
Copy link
Contributor

@RadekManak RadekManak commented Jun 10, 2025 •
edited
Loading

This PR primarily brings in uv for dependency management and ruff for linting and auto formatting.

  • uv simplifies venv management and ensures tests run with the minimal set of specified dependencies.
  • ruff combines all formatting and linting rules into one step. Improving performance and enabling auto format.
  • Make targets are updated to make full advantage of uv and ruff
  • ContainerFile is updated to python 3.12 and go 1.24.3
  • All tooling configuration is now in pyproject.toml
  • Autoformat was run, and minor changes were made to fix new lint rules.

Draft until openshift/release#65749 merges

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 10, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2025
@RadekManak RadekManak mentioned this pull request Jun 10, 2025
Merged
@RadekManak RadekManak marked this pull request as ready for review June 11, 2025 15:48
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 11, 2025
@openshift-ci openshift-ci bot requested review from damdo and nrb June 11, 2025 15:48
damdo
damdo reviewed Jun 16, 2025
View reviewed changes
Copy link
Contributor

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks @RadekManak that's a nice update!
I'll add my LGTM once CI is green

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, RadekManak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RadekManak RadekManak force-pushed the overhaul-tooling branch 2 times, most recently from a4a5175 to 6982d0b Compare June 26, 2025 12:26
damdo
damdo reviewed Jun 26, 2025
View reviewed changes
Makefile Outdated
Comment on lines +41 to +44
echo "=== Debug Information ==="
echo "Current working directory: $(pwd)"
echo "Current user: $(whoami)"
echo "Current user ID: $(id)"
Copy link
Contributor

@damdo damdo Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC you need to use double dollars in Make to escape shell dollars. e.g. $$(pwd)

@RadekManak RadekManak marked this pull request as draft June 26, 2025 12:35
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2025
@RadekManak
Copy link
Contributor Author

RadekManak commented Jun 26, 2025

/retest

@RadekManak
Copy link
Contributor Author

RadekManak commented Jun 27, 2025

/retest

@RadekManak
Copy link
Contributor Author

RadekManak commented Jun 27, 2025

/retest

@RadekManak RadekManak force-pushed the overhaul-tooling branch 2 times, most recently from 1390ce1 to 2be846c Compare June 27, 2025 13:56
@RadekManak
Copy link
Contributor Author

RadekManak commented Jun 27, 2025

/retest

@RadekManak
Copy link
Contributor Author

RadekManak commented Jun 27, 2025

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 27, 2025

@RadekManak: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 56851ca link true /test unit
ci/prow/lint 56851ca link true /test lint

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nrb nrb Awaiting requested review from nrb

1 more reviewer

@damdo damdo damdo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RadekManak @damdo