Add operator-specific PR-gate regression suites - #1
Conversation
|
IMO, I think we can remove the below cases from [Level0] to simply not let the gating test take a lot of time. |
Tag a curated set of 19 existing tests with PRGate and operator ownership markers, and register one non-disruptive suite for cluster-logging-operator PRs and one for loki-operator PRs. Shared CLO-to-LokiStack integration tests run in both suites.\n\nKeep PR-gate membership separate from Level0 conformance classification. The reduced set favors distinct reconciliation, validation, RBAC, configuration, and representative delivery paths while leaving expensive, redundant, platform-specific, timing-sensitive, and historically unstable coverage to periodic jobs.\n\nDocument the new suites and annotations in README.md.
df0a4bd to
83beb5f
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Thanks — agreed that 31 tests is too large for a blocking presubmit, and I have reduced the candidate set substantially. I don't think one Critical case per supported log store should be the sole selection rule. The Critical label represents product priority, while a blocking gate also needs high stability, bounded runtime, actionable failures, and coverage of core operator reconciliation and validation paths. The complete output-store configuration matrix is already better covered by CLO's per-output unit tests and the periodic e2e jobs. I removed
I also removed The PR now uses a dedicated When the presubmit jobs are added in |
|
@IshwarKanse: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
The failing The CI builder image ( The CI job currently runs: commands: HOME=/tmp make buildIt should clear the builder's inherited vendor mode (or explicitly select module mode), for example: commands: GOFLAGS= HOME=/tmp make buildAlternatively, the repository Makefile can clear |
Goal
Run a small, high-signal regression set on
cluster-logging-operatorandlokipull requests so operator regressions are caught before merge, without running the full ~158-test e2e suite on every PR.Each operator gets its own suite:
openshift-logging-e2e-tests/cluster-logging-operatoropenshift-logging-e2e-tests/loki-operatorThe suites select tests using a dedicated
[PRGate]marker plus[CLO]or[LokiOperator]. PR-gate membership is intentionally separate from[Level0], which controls membership in OpenShift's global conformance suites.What changed
openshift-testsrunner honors each test's existing[Serial]marker, so separate parallel and serial suites are unnecessary.README.md.Selection principles
A blocking presubmit test should provide an actionable signal for code changed in that repository. Selection therefore favors tests that:
The Critical/High/Medium case classification is considered, but is not the sole gating criterion. Product criticality does not guarantee that an e2e test is fast or reliable enough to block every PR.
cluster-logging-operator suite — 11 tests
loki-operator suite — 10 tests
adminGroupsaccessTests intentionally left to periodic coverage
Runtime and rollout
This reduction is expected to bring the CLO suite to roughly 45–90 minutes and the Loki Operator suite to roughly 1–2 hours, but these are planning estimates rather than measured CI durations. The Loki suite is mostly serial because its tests reconcile cluster-level LokiStack resources.
The corresponding
openshift/releasepresubmits should initially run withoptional: true. Their actual duration and pass rate should be collected in CI/Sippy, and only tests that meet the team's reliability and runtime threshold should be promoted to blocking status. The complete suite remains covered by periodic jobs.Verification
make build[PRGate]tests.[PRGate][CLO].[PRGate][LokiOperator].[PRGate]test is[Disruptive].The actual presubmit configuration in
openshift/releaseis intentionally a follow-up change after this test selection is reviewed.