build(konflux): convert 1 image from network_mode open to hermetic #7747
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove network_mode: open configuration from konflux section to allow default hermetic mode for openshift-enterprise-hyperkube. This change enables build isolation and improves security by preventing network access during container builds for these components. Backport from openshift-4.21 to openshift-4.16. Note: ose-insights-runtime-extractor and openstack-resource-controller do not exist in this version.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold broken build |
openshift-ci
bot
added
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Convert 1 image from network_mode: open to hermetic mode by removing konflux network_mode configuration, allowing it to use the default hermetic build isolation.
Problem
Before: openshift-enterprise-hyperkube was configured with network_mode: open in its konflux section, allowing network access during builds.
After: Image now uses the default hermetic mode, providing build isolation and improved security by preventing network access during container builds.
Changes
Technical Notes
This change enables build isolation for this component, improving security posture and aligning with the project's goal of converting all images to hermetic builds.
Backport from openshift-4.21 to openshift-4.16.
Note: ose-insights-runtime-extractor and openstack-resource-controller do not exist in this version.