-
Notifications
You must be signed in to change notification settings - Fork 85
CNTRLPLANE-1732: feat(hcp): add HyperShift cluster command generator plugin #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNTRLPLANE-1732: feat(hcp): add HyperShift cluster command generator plugin #94
Conversation
|
@jparrill: This pull request references CNTRLPLANE-1732 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hi @jparrill. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This is a sample execution of the new plugin: |
|
/ok-to-test |
|
@jparrill: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple nits, but looks good otherwise. make update is needed
| "description": "A plugin to analyze and report on must-gather data" | ||
| }, | ||
| { | ||
| "name": "hcp", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit, could we call the plugin "hypershift"? It'd be more discoverable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was doubting that too, actually my first iteration was using hypershift but hcp was smaller and easy to remember, also the users are used to use that command outside of claude (we have 2 CLIs hypershift (dev supported) hcp (fully customer supported)). I think hcp is smaller and maybe better.
It's there any way to call the plugin hypershift at marketplace level but use the command as hcp (maybe it's confusing too)?
| @@ -0,0 +1,509 @@ | |||
| --- | |||
| name: HyperShift Agent Provider | |||
| description: Implementation guide for creating HyperShift clusters using the Agent provider for bare metal and edge deployments | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skill descriptions should briefly explain like "Use this skill when.... " so Claude knows when to use it, skills should be usable outside of the / commands, otherwise they don't need to be skills. This is the only text that's put into the context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me update. the skills :)
Add new hcp plugin that generates hypershift create cluster commands from natural language descriptions across multiple cloud providers. Features: - Multi-provider support (AWS, Azure, KubeVirt, OpenStack, PowerVS, Agent) - Provider-specific skills with specialized implementation guidance - Interactive parameter collection and validation - Smart defaults and best practices application - Network conflict prevention (critical for KubeVirt) - Security validation for credentials and sensitive data Architecture: - Main command: /hcp:generate acts as orchestrator - Provider skills: Specialized knowledge for each platform - Modular design: Single source of truth per provider - Extensible: Easy to add new providers The plugin generates ready-to-execute commands rather than provisioning clusters directly. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Juan Manuel Parrilla Madrid <[email protected]>
29fcb64 to
f1fb091
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jparrill, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
Add HCP plugin that generates
hypershift create clustercommands from natural language descriptions across 6 cloud providers.Features
/hcp:generate <provider> <description>Example
🤖 Generated with Claude Code