-
Notifications
You must be signed in to change notification settings - Fork 85
feat: add microshift-prow-jobs plugin #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
/retest |
|
/test images |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice contribution thanks, a few comments below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could it just be part of prow-jobs? microshift-prow-jobs feels a little too specialized. Either a microshift plugin, or contribute it to the prow-jobs plugin will make it more discoverable for other folks who might be debugging various CI jobs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's value on a more specialized prow-job plugin only for microshift because MicroShift tests are not based on ginkgo test suites but on Robot Framework.
plugins/microshift-prow-jobs/commands/get-prow-ci-e2e-job-info.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See https://github.com/openshift-eng/ai-helpers/tree/main/plugins/prow-job/skills
This structure essentially creates a "scripts" skill, I'd name it and organize it in its own dir
| **Actions**: | ||
| 1. Construct base artifact URL: | ||
| ``` | ||
| https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/logs/<job-name>/<job-id>/artifacts/<job-type>/openshift-microshift-e2e-metal-tests/artifacts/scenario-info/<scenario-name>/ | ||
| ``` | ||
| 2. Construct specific artifact URLs: | ||
| - JUnit XML: `<base-url>/junit.xml` | ||
| - Boot log: `<base-url>/boot_and_run.log` | ||
| - Debug log: `<base-url>/rf-debug.log` | ||
| - Phase logs: `<base-url>/phase_*/*.log` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the prow job tools have settled on using gcs utils to browse the buckets instead, its a little faster I think than trying to navigate the gcsweb interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good as it is because it's pointing to just the 4 final files listed which should be easy to read by the LLM.
rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
0bdc57d to
22ba531
Compare
22ba531 to
a05beda
Compare
rh-pre-commit.check-secrets: ENABLED
…elpers into microshift-prow-jobs_plugin rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: agullon The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: agullon The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
@stbenjam thank you for comments. Creating and testing this plugin really helped me to understand how a LLM "is thinking", how I should ask tasks and what to expect as an output. It really shines when the task/skill is small and concise. Also, it works great, in particular when generating the output, with human-readable text (for example md files) but not with structure data (json format.). |
What this PR does / why we need it:
This PR adds a new Claude Code plugin for analyzing MicroShift Prow CI job executions and test results. The microshift-prow-job plugin provides automated analysis tools for MicroShift CI jobs running on OpenShift's Prow CI infrastructure. It helps developers and QE engineers quickly understand test results, diagnose failures, and track MicroShift versions across different test configurations.
Commands Added:
/microshift-prow-job:analyze-job <job-url>/microshift-prow-job:analyze-test-scenario <job-url> [scenario-name]Special notes for your reviewer: