-
Notifications
You must be signed in to change notification settings - Fork 157
add json functions #3559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
add json functions #3559
+1,797
−240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
Signed-off-by: xinyual <[email protected]>
Signed-off-by: xinyual <[email protected]>
Loading status checks…
Signed-off-by: xinyual <[email protected]>
Signed-off-by: xinyual <[email protected]>
Loading status checks…
Signed-off-by: xinyual <[email protected]>
Why we didn't leverage the Calcite builtin JSON functions, for instance |
I have listed the functions above and try to reuse calcite code |
Loading status checks…
Signed-off-by: xinyual <[email protected]>
Loading status checks…
Signed-off-by: xinyual <[email protected]>
Loading status checks…
Signed-off-by: xinyual <[email protected]>
Signed-off-by: xinyual <[email protected]>
Signed-off-by: xinyual <[email protected]>
Signed-off-by: xinyual <[email protected]>
Signed-off-by: xinyual <[email protected]>
Signed-off-by: xinyual <[email protected]>
Signed-off-by: xinyual <[email protected]>
Loading status checks…
Signed-off-by: xinyual <[email protected]>
Loading status checks…
LantaoJin
approved these changes
Jun 4, 2025
core/src/main/java/org/opensearch/sql/expression/function/PPLFuncImpTable.java
Outdated
Show resolved
Hide resolved
LantaoJin
requested changes
Jun 4, 2025
penghuo
previously approved these changes
Jun 4, 2025
Signed-off-by: xinyual <[email protected]>
Loading status checks…
Signed-off-by: xinyual <[email protected]>
Loading status checks…
Signed-off-by: xinyual <[email protected]>
Signed-off-by: xinyual <[email protected]>
Loading status checks…
Signed-off-by: xinyual <[email protected]>
CI failures |
Loading status checks…
Force push to revert useless change and resolve DCO problems. |
Loading status checks…
Signed-off-by: xinyual <[email protected]>
Loading status checks…
Signed-off-by: xinyual <[email protected]>
Loading status checks…
Signed-off-by: xinyual <[email protected]>
LantaoJin
approved these changes
Jun 7, 2025
penghuo
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here we add json related functions to align with spark
Here is the argument and description of functions
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
#3565
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.