Add SQLQuery Utils support for Vaccum queries #3269
+27
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siritejagaddameedi
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG and
ykmr1224
as code owners
ykmr1224
reviewed
Jan 28, 2025
|
Build failed due to style check. |
noCharger
reviewed
Jan 29, 2025
Comment on lines
318
to
342
| @Override | ||
| public Void visitVacuumCoveringIndexStatement( | ||
| FlintSparkSqlExtensionsParser.VacuumCoveringIndexStatementContext ctx) { | ||
| indexQueryDetailsBuilder.indexQueryActionType(IndexQueryActionType.VACUUM); | ||
| indexQueryDetailsBuilder.indexType(FlintIndexType.COVERING); | ||
| return super.visitVacuumCoveringIndexStatement(ctx); | ||
| } | ||
|
|
||
| @Override | ||
| public Void visitVacuumSkippingIndexStatement( | ||
| FlintSparkSqlExtensionsParser.VacuumSkippingIndexStatementContext ctx) { | ||
| indexQueryDetailsBuilder.indexQueryActionType(IndexQueryActionType.VACUUM); | ||
| indexQueryDetailsBuilder.indexType(FlintIndexType.SKIPPING); | ||
| return super.visitVacuumSkippingIndexStatement(ctx); | ||
| } | ||
|
|
||
| @Override | ||
| public Void visitVacuumMaterializedViewStatement( | ||
| FlintSparkSqlExtensionsParser.VacuumMaterializedViewStatementContext ctx) { | ||
| indexQueryDetailsBuilder.indexQueryActionType(IndexQueryActionType.VACUUM); | ||
| indexQueryDetailsBuilder.indexType(FlintIndexType.MATERIALIZED_VIEW); | ||
| indexQueryDetailsBuilder.mvName(ctx.mvName.getText()); | ||
| return super.visitVacuumMaterializedViewStatement(ctx); | ||
| } | ||
|
|
There was a problem hiding this comment.
what's the use case for adding Vaccum in async-query-core?
There was a problem hiding this comment.
Whenever we call SQLQueryUtils with vacuum query, it will fail to parse the query.
added 3 commits
January 30, 2025 09:07
Signed-off-by: Siri Teja Gaddameedi <[email protected]>
Signed-off-by: Siri Teja Gaddameedi <[email protected]>
Signed-off-by: Siri Teja Gaddameedi <[email protected]>
Siritejagaddameedi
force-pushed
the
iris_vaccum
branch
from
d2ac2fa to
f8642a5
Compare
ykmr1224
approved these changes
Jan 30, 2025
ykmr1224
requested changes
Jan 30, 2025
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add SQLQueryUtils support for Vacuum queries
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.