Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete compose version specifier #5326

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

SimonCW
Copy link
Contributor

@SimonCW SimonCW commented Feb 17, 2025

Description

Version specifier for docker compose is obsolete. See: https://docs.docker.com/reference/compose-file/version-and-name/#version-top-level-element-obsolete

See this PR to collect changes across opensearch-project repos: opensearch-project/documentation-website#8606

@gaiksaya
Copy link
Member

Need --- for yaml linting. Can you please fix it?
Thanks!

@peterzhuamazon
Copy link
Member

Need --- for yaml linting. Can you please fix it? Thanks!

Hi @SimonCW yes maybe also leave --- untouched in opensearch-project/project-website#3652?

Thanks.

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.04%. Comparing base (ca41b1b) to head (3796572).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5326   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files         202      202           
  Lines        7042     7042           
=======================================
  Hits         6482     6482           
  Misses        560      560           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SimonCW
Copy link
Contributor Author

SimonCW commented Feb 17, 2025

@peterzhuamazon, done, sorry for the mix-up!

@gaiksaya gaiksaya merged commit 95f1b58 into opensearch-project:main Feb 17, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants