make memory optional in conversational agent #3626
Open
+79
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jngz-es
requested review from
b4sjoo,
dhrubo-os,
mingshl,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
xinyual
as code owners
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
pyek-bot
reviewed
Mar 17, 2025
| ) | ||
| .build() | ||
| ); | ||
| if (!StringUtils.isEmpty(sessionId)) { |
There was a problem hiding this comment.
let's inverse this? if (StringUtils.isEmpty()) { return emptyList; }
pyek-bot
reviewed
Mar 17, 2025
Comment on lines
+229
to
+326
| List<ModelTensors> traceTensors = (conversationIndexMemory == null) | ||
| ? new ArrayList<>() | ||
| : createModelTensors(sessionId, parentInteractionId); |
There was a problem hiding this comment.
what about passing conversationIndexMemory to this method and returning empty list rather than using ternary operator here?
*ignore, seems like it will affect a lot of other methods using this
pyek-bot
reviewed
Mar 17, 2025
| @@ -121,12 +122,17 @@ public MLChatAgentRunner( | |||
|
|
|||
| @Override | |||
| public void run(MLAgent mlAgent, Map<String, String> params, ActionListener<Object> listener) { | |||
| String memoryType = mlAgent.getMemory().getType(); | |||
| String memoryType = mlAgent.getMemory() == null ? null : mlAgent.getMemory().getType(); | |||
There was a problem hiding this comment.
does the current behavior throw NPE here? wondering if there is some validation in the REST/Transport layer to check for memory, didn't see any tho
There was a problem hiding this comment.
Memory is created by default in MLAgentExecutor right? so should we change some code there as well
jngz-es
force-pushed
the
optional_memory
branch
2 times, most recently
from
d2aa325 to
832dfb9
Compare
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Signed-off-by: Jing Zhang <[email protected]>
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3626 +/- ##
============================================
+ Coverage 80.28% 80.39% +0.11%
- Complexity 7821 7913 +92
============================================
Files 683 693 +10
Lines 34519 34847 +328
Branches 3840 3875 +35
============================================
+ Hits 27714 28016 +302
+ Misses 5099 5097 -2
- Partials 1706 1734 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
#3614
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.