Skip to content

Update bundled JDK to JDK-25 #19698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update bundled JDK to JDK-25 #19698

wants to merge 1 commit into from
+5 −4

Conversation

andrross
Copy link
Member

Related Issues

Resolves #19314

Check List

  • Functionality includes testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@andrross andrross requested a review from a team as a code owner October 20, 2025 19:59
@github-actions github-actions bot added Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. enhancement Enhancement or improvement to existing feature or request release v3.3.0 labels Oct 20, 2025
@andrross andrross mentioned this pull request Oct 20, 2025
Open
@peterzhuamazon
Copy link
Member

peterzhuamazon commented Oct 20, 2025 •
edited
Loading

Pending merging until these two are merged and updated on dockerhub/ami, so that this PR can be properly tested with JDK 25-enabled gradle check.

Thanks.

@github-actions
Copy link
Contributor

❌ Gradle check result for 0d03596: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 0d03596: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@andrross andrross marked this pull request as draft October 20, 2025 22:34
@andrross
Copy link
Member Author

Let's not merge this yet. I'm able to get the following to fail about reliably (about 75 out of 100 iterations fails):

./gradlew ':modules:lang-painless:test' --tests 'org.opensearch.painless.FunctionRefTests.testReturnVoidDef'  -Dtests.iters=100

The test is expecting ScriptException with a LambdaConversionException as the cause, but about 75% of the time it is a java.lang.Error with a LambdaConversionException as the cause.

@github-actions
Copy link
Contributor

❌ Gradle check result for 0d03596: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@andrross andrross added v3.4.0 Issues and PRs related to version 3.4.0 and removed v3.3.0 labels Oct 20, 2025
@andrross
Copy link
Member Author

It looks like there's a behavior change to wrap checked exceptions with java.lang.Error in this commit in the JDK that's causing the issue here.

@andrross andrross mentioned this pull request Oct 21, 2025
Merged
1 task
reta
reta reviewed Oct 22, 2025
View reviewed changes
gradle/libs.versions.toml

bundled_jdk_vendor = "adoptium"
bundled_jdk = "24.0.2+12"
bundled_jdk = "25+36"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just got new releases today https://blogs.oracle.com/java/post/jdk-2501-2109-17017-11029-and-8u471-have-been-released (but we could update after)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah Reta, I have yet to see that showing on temurin, so we can definitely just update later.

jainankitk
jainankitk approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@jainankitk jainankitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, ready to go after #19706 and infra updates - #19698 (comment)!

@github-actions
Copy link
Contributor

❌ Gradle check result for 77f5b69: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 22, 2025
Open
@github-actions
Copy link
Contributor

❌ Gradle check result for 77f5b69: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 22, 2025
Open
@andrross
Update bundled JDK to JDK-25
3162ad3 
Signed-off-by: Andrew Ross <[email protected]>
@andrross andrross marked this pull request as ready for review October 22, 2025 22:02
@github-actions
Copy link
Contributor

❌ Gradle check result for 3162ad3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reta reta reta approved these changes

@peterzhuamazon peterzhuamazon peterzhuamazon left review comments

@jainankitk jainankitk jainankitk approved these changes

Assignees

No one assigned

Labels

Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. enhancement Enhancement or improvement to existing feature or request release v3.4.0 Issues and PRs related to version 3.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update bundled JDK to JDK25

4 participants

@andrross @peterzhuamazon @reta @jainankitk