Skip to content

Conversation

lawofcycles
Copy link

Description

This PR fixes a NullPointerException that occurs when restoring remote snapshots when shard size information is not available in the ClusterInfo cache.

The validateSearchableSnapshotRestorable method in RestoreService attempts to calculate the total size of existing remote snapshot shards.
When ClusterInfo.getShardSize() returns null (which is valid behavior when shard size info is unavailable), the stream operation mapToLong(Long::longValue) throws a NullPointerException.

Related Issues

Resolves #19349

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@lawofcycles lawofcycles requested a review from a team as a code owner October 19, 2025 09:05
@github-actions github-actions bot added bug Something isn't working Storage:Snapshots labels Oct 19, 2025
Signed-off-by: Sotaro Hikita <[email protected]>
Copy link
Contributor

❌ Gradle check result for c2f7eb8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@lawofcycles
Copy link
Author

The CI failure appears to be unrelated to my changes. The error is occurring in the Azure fixture Docker containers:

ERROR: for azure-fixture_azure-fixture-repositories-metering_1  cannot stop container: 
container PID is zombie and can not be killed

This seems to be an infrastructure/flaky test issue rather than a problem with the NPE fix in RestoreService.

Signed-off-by: Sotaro Hikita <[email protected]>
@lawofcycles lawofcycles force-pushed the fix-19349-npe-restore-remote-snapshot branch from 8eacfc4 to 2baa1ab Compare October 19, 2025 18:19
Copy link
Contributor

❌ Gradle check result for 2baa1ab: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-project-automation github-project-automation bot moved this to 👀 In review in Storage Project Board Oct 20, 2025
Copy link
Contributor

❌ Gradle check result for 2baa1ab: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Storage:Snapshots

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

[BUG] NullPointerException when creating remote index from snapshot

2 participants