Fix NPE in validateSearchableSnapshotRestorable when shard size is unavailable #19684
+79
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a NullPointerException that occurs when restoring remote snapshots when shard size information is not available in the ClusterInfo cache.
The
validateSearchableSnapshotRestorable
method in RestoreService attempts to calculate the total size of existing remote snapshot shards.When
ClusterInfo.getShardSize()
returns null (which is valid behavior when shard size info is unavailable), the stream operation mapToLong(Long::longValue) throws a NullPointerException.Related Issues
Resolves #19349
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.