[Java Agent] Allow JRT protocol URLs in protection domain extraction #19683

rithin-pullela-aws · 2025-10-18T06:41:23Z

Description

Add filtering for jrt: protocol URLs in StackCallerProtectionDomainChainExtractor
Added test case testFiltersJrtProtocolWithoutMockito() to verify the filtering behavior

Related Issues

Resolves opensearch-project/ml-commons#4209

Check List

Functionality includes testing.
API changes companion pull request created, if applicable.
Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2025-10-18T08:53:45Z

❌ Gradle check result for 5b1a49f: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

cwperks · 2025-10-18T11:57:26Z

Re-ran the CI. Jenkins didn't pick it up on the first try.

cwperks · 2025-10-18T11:58:34Z

@getsaurabh02 @peterzhuamazon Can this be included in the 3.3.1 patch release?

@owaiskazi19 @rithin-pullela-aws to provide impact on ml-commons. In some distributions, agentic search is hitting issues with the java agent due to this. See opensearch-project/ml-commons#4209

.../agent/src/test/java/org/opensearch/javaagent/StackCallerProtectionDomainExtractorTests.java

github-actions · 2025-10-18T13:59:10Z

❌ Gradle check result for 5b1a49f: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

ylwu-amzn · 2025-10-18T16:06:37Z

This PR is to solve this issue opensearch-project/ml-commons#4209 right ? Not opensearch-project/ml-commons#4194

owaiskazi19 · 2025-10-18T17:30:20Z

This PR is to solve this issue opensearch-project/ml-commons#4209 right ? Not opensearch-project/ml-commons#4194

Yes, updated the description

github-actions · 2025-10-18T18:50:43Z

❌ Gradle check result for 52a614f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-10-18T20:00:37Z

❌ Gradle check result for 52a614f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

cwperks · 2025-10-18T21:55:00Z

Need to fix the compiler warnings. These are due to the test added in the PR.

 [3.3.0] > Task :libs:agent-sm:agent:compileJava
 [3.3.0] /home/ubuntu/.gradle/caches/modules-2/files-2.1/net.bytebuddy/byte-buddy/1.17.7/3856bfab61beb23e099a0d6629f2ba8de4b98ace/byte-buddy-1.17.7.jar(/net/bytebuddy/implementation/bytecode/assign/Assigner.class): warning: Cannot find annotation method 'value()' in type 'SuppressFBWarnings': class file for edu.umd.cs.findbugs.annotations.SuppressFBWarnings not found
 [3.3.0] /home/ubuntu/.gradle/caches/modules-2/files-2.1/net.bytebuddy/byte-buddy/1.17.7/3856bfab61beb23e099a0d6629f2ba8de4b98ace/byte-buddy-1.17.7.jar(/net/bytebuddy/implementation/bytecode/assign/Assigner.class): warning: Cannot find annotation method 'justification()' in type 'SuppressFBWarnings'
 [3.3.0] /home/ubuntu/.gradle/caches/modules-2/files-2.1/net.bytebuddy/byte-buddy/1.17.7/3856bfab61beb23e099a0d6629f2ba8de4b98ace/byte-buddy-1.17.7.jar(/net/bytebuddy/description/type/TypeDescription$ForLoadedType.class): warning: Cannot find annotation method 'value()' in type 'SuppressFBWarnings'
 [3.3.0] /home/ubuntu/.gradle/caches/modules-2/files-2.1/net.bytebuddy/byte-buddy/1.17.7/3856bfab61beb23e099a0d6629f2ba8de4b98ace/byte-buddy-1.17.7.jar(/net/bytebuddy/description/type/TypeDescription$ForLoadedType.class): warning: Cannot find annotation method 'justification()' in type 'SuppressFBWarnings'
...

You can fix by adding compileOnly dependency on spotbugs-annotations in libs/agent-sm/agent/build.gradle

i.e. compileOnly("com.github.spotbugs:spotbugs-annotations:4.9.7")

owaiskazi19 · 2025-10-21T00:56:52Z

@cwperks gradle check is failing with. Will rebase

Execution failed for task ':distribution:bwc:minor:buildBwcLinuxTar'.
> Building 3.3.0 didn't generate expected file /var/jenkins/workspace/gradle-check/search/distribution/bwc/minor/build/bwc/checkout-3.3/distribution/archives/linux-tar/build/distributions/opensearch-min-3.3.0-SNAPSHOT-linux-x64.tar.gz

github-actions · 2025-10-21T03:13:09Z

❌ Gradle check result for a5d9659: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-10-21T06:24:13Z

❌ Gradle check result for a5d9659: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-10-21T07:45:19Z

❌ Gradle check result for a5d9659: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: rithin-pullela-aws <[email protected]>

Signed-off-by: Owais Kazi <[email protected]>

github-actions · 2025-10-21T21:20:40Z

✅ Gradle check result for 37a938e: SUCCESS

codecov · 2025-10-21T21:21:02Z

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.09%. Comparing base (3ffa49a) to head (37a938e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...ent/StackCallerProtectionDomainChainExtractor.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #19683      +/-   ##
============================================
+ Coverage     73.07%   73.09%   +0.02%     
- Complexity    70741    70765      +24     
============================================
  Files          5732     5732              
  Lines        324140   324141       +1     
  Branches      46922    46922              
============================================
+ Hits         236853   236945      +92     
+ Misses        68117    68038      -79     
+ Partials      19170    19158      -12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…19683) * [Java Agent] Allow JRT protocol URLs in protection domain extraction Signed-off-by: rithin-pullela-aws <[email protected]> * Add changelog Signed-off-by: rithin-pullela-aws <[email protected]> * Use static imports Signed-off-by: rithin-pullela-aws <[email protected]> * Add spotbugs dependency Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: rithin-pullela-aws <[email protected]> Signed-off-by: Owais Kazi <[email protected]> Co-authored-by: Owais Kazi <[email protected]> (cherry picked from commit 3443d27) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

andrross · 2025-10-21T23:05:24Z

libs/agent-sm/build.gradle

 testingConventions.enabled = false
+
+dependencies {
+  compileOnly "com.github.spotbugs:spotbugs-annotations:4.9.7"


Why was this added?

See #19683 (comment)

For the warnings reported here

…19683) (#19709) * [Java Agent] Allow JRT protocol URLs in protection domain extraction * Add changelog * Use static imports * Add spotbugs dependency --------- (cherry picked from commit 3443d27) Signed-off-by: rithin-pullela-aws <[email protected]> Signed-off-by: Owais Kazi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Owais Kazi <[email protected]>

…pensearch-project#19683) * [Java Agent] Allow JRT protocol URLs in protection domain extraction Signed-off-by: rithin-pullela-aws <[email protected]> * Add changelog Signed-off-by: rithin-pullela-aws <[email protected]> * Use static imports Signed-off-by: rithin-pullela-aws <[email protected]> * Add spotbugs dependency Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: rithin-pullela-aws <[email protected]> Signed-off-by: Owais Kazi <[email protected]> Co-authored-by: Owais Kazi <[email protected]>

rithin-pullela-aws requested a review from a team as a code owner October 18, 2025 06:41

cwperks reviewed Oct 18, 2025

View reviewed changes

.../agent/src/test/java/org/opensearch/javaagent/StackCallerProtectionDomainExtractorTests.java Outdated Show resolved Hide resolved

peterzhuamazon mentioned this pull request Oct 18, 2025

[RELEASE] Release version 3.3.1 opensearch-project/opensearch-build#5784

Closed

65 tasks

github-actions bot added the backport PRs or issues specific to backporting features or enhancments label Oct 18, 2025

owaiskazi19 added the backport 3.3 Backport to 3.3 branch label Oct 18, 2025

rithin-pullela-aws mentioned this pull request Oct 20, 2025

[BUG] Failed to get tools from external MCP server opensearch-project/ml-commons#4209

Closed

owaiskazi19 force-pushed the jrt-fix branch from 52a614f to a5d9659 Compare October 21, 2025 01:10

rithin-pullela-aws and others added 4 commits October 21, 2025 13:02

[Java Agent] Allow JRT protocol URLs in protection domain extraction

604a222

Signed-off-by: rithin-pullela-aws <[email protected]>

Add changelog

9223b78

Signed-off-by: rithin-pullela-aws <[email protected]>

Use static imports

c2f06ab

Signed-off-by: rithin-pullela-aws <[email protected]>

Add spotbugs dependency

37a938e

Signed-off-by: Owais Kazi <[email protected]>

owaiskazi19 force-pushed the jrt-fix branch from a5d9659 to 37a938e Compare October 21, 2025 20:02

cwperks approved these changes Oct 21, 2025

View reviewed changes

owaiskazi19 merged commit 3443d27 into opensearch-project:main Oct 21, 2025
32 of 33 checks passed

opensearch-trigger-bot bot mentioned this pull request Oct 21, 2025

[Backport 3.3] [Java Agent] Allow JRT protocol URLs in protection domain extraction #19709

Merged

andrross reviewed Oct 21, 2025

View reviewed changes

This was referenced Oct 22, 2025

[AUTOCUT] Gradle Check Flaky Test Report for AzureBlobStoreRepositoryTests #14291

Open

[AUTOCUT] Gradle Check Flaky Test Report for AwarenessAllocationIT #17930

Open

[AUTOCUT] Gradle Check Flaky Test Report for ClientYamlTestSuiteIT #14319

Open

peterzhuamazon mentioned this pull request Oct 23, 2025

[RELEASE] Release version 3.3.2 opensearch-project/opensearch-build#5799

Open

65 tasks

[Java Agent] Allow JRT protocol URLs in protection domain extraction #19683

[Java Agent] Allow JRT protocol URLs in protection domain extraction #19683

Conversation

rithin-pullela-aws commented Oct 18, 2025 • edited by owaiskazi19 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Check List

Uh oh!

github-actions bot commented Oct 18, 2025

Uh oh!

cwperks commented Oct 18, 2025

Uh oh!

cwperks commented Oct 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 18, 2025

Uh oh!

ylwu-amzn commented Oct 18, 2025

Uh oh!

owaiskazi19 commented Oct 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 18, 2025

Uh oh!

github-actions bot commented Oct 18, 2025

Uh oh!

cwperks commented Oct 18, 2025

Uh oh!

owaiskazi19 commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 21, 2025

Uh oh!

github-actions bot commented Oct 21, 2025

Uh oh!

github-actions bot commented Oct 21, 2025

Uh oh!

github-actions bot commented Oct 21, 2025

Uh oh!

codecov bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

andrross Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

cwperks Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

owaiskazi19 Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rithin-pullela-aws commented Oct 18, 2025 •

edited by owaiskazi19

Loading

cwperks commented Oct 18, 2025 •

edited

Loading

owaiskazi19 commented Oct 18, 2025 •

edited

Loading

owaiskazi19 commented Oct 21, 2025 •

edited

Loading

codecov bot commented Oct 21, 2025 •

edited

Loading