Using gt to make constraint test during rebalance #17324
Conversation
bugmakerrrrrr
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
❌ Gradle check result for 12364d5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: panguixin <[email protected]>
bugmakerrrrrr
force-pushed
the
rebalance
branch
from
12364d5 to
d4e101a
Compare
|
❌ Gradle check result for d4e101a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: panguixin <[email protected]>
| return (params) -> { | ||
| int primaryShardCount = params.getNode().numPrimaryShards(); | ||
| int allowedPrimaryShardCount = (int) Math.ceil(params.getBalancer().avgPrimaryShardsPerNode() * (1 + buffer)); | ||
| return primaryShardCount >= allowedPrimaryShardCount; | ||
| return rebalance ? primaryShardCount > allowedPrimaryShardCount : primaryShardCount >= allowedPrimaryShardCount; |
There was a problem hiding this comment.
using gt for comparison is equivalent to assigning the variable buffer as 1/params.getBalancer().avgPrimaryShardsPerNode()
|
❌ Gradle check result for 9e1ad2e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Description
Today, we use gte to make constraint test during allocation and rebalance.
OpenSearch/server/src/main/java/org/opensearch/cluster/routing/allocation/ConstraintTypes.java
Lines 71 to 73 in c82fffe
When the number of primary shards is not divisible by the number of nodes, nodes that are over-allocated primary shards are assigned a high weight, causing them to be unavailable for allocation of replicas during rebalance. The flaky test #14327 is the result of this.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.