-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added leader/follower check attempt failure metrics #17254
base: main
Are you sure you want to change the base?
Added leader/follower check attempt failure metrics #17254
Conversation
Signed-off-by: Smit Patel <[email protected]>
❌ Gradle check result for b80b110: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for 7463a9d: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17254 +/- ##
============================================
- Coverage 72.43% 72.32% -0.12%
- Complexity 65725 65742 +17
============================================
Files 5318 5318
Lines 305675 305681 +6
Branches 44350 44350
============================================
- Hits 221408 221073 -335
- Misses 66055 66479 +424
+ Partials 18212 18129 -83 ☔ View full report in Codecov by Sentry. |
@shwetathareja please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add some tests here? Maybe in LeaderCheckerTests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we reset it to zero once we have a successful check
We want to have a total view of all the failures, not just consecutive ones |
❌ Gradle check result for 04507e7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Smit Patel <[email protected]>
04507e7
to
984cde6
Compare
❕ Gradle check result for 984cde6: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Description
This PR adds metrics for each individual leader/follower check attempt failure. It can help in understanding how frequently/intermittently the checks are failing.
Related Issues
Resolves #17253
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.