Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JDK 18 EA builds #1710

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Support JDK 18 EA builds #1710

merged 1 commit into from
Dec 13, 2021

Conversation

reta
Copy link
Collaborator

@reta reta commented Dec 13, 2021

Signed-off-by: Andriy Redko [email protected]

Description

Since the integration of [1] into JDK-18, setting SecurityManager now requires JVM command line option to enable it explicitly. Running OpenSearch server or tests on latest JDK-18 EA builds fails with exception:

Exception in thread "main" java.lang.UnsupportedOperationException: The Security Manager is deprecated and will be removed in a future release
        at java.base/java.lang.System.setSecurityManager(System.java:416)
        at org.opensearch.bootstrap.OpenSearch.main(OpenSearch.java:91)

[1] https://bugs.openjdk.java.net/browse/JDK-8270380

Issues Resolved

Part of #1687

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andriy Redko <[email protected]>
@reta reta requested a review from a team as a code owner December 13, 2021 14:56
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 68e3ba5
Log 1462

Reports 1462

@dblock
Copy link
Member

dblock commented Dec 13, 2021

How timely given the log4j RCE to get rid of security manager 😠

@dblock dblock merged commit 069e229 into opensearch-project:main Dec 13, 2021
@dblock
Copy link
Member

dblock commented Dec 13, 2021

I forget, what did we do for 1.x? Are we backporting this?

@dblock dblock added backport 1.x pending backport Identifies an issue or PR that still needs to be backported labels Dec 13, 2021
@reta
Copy link
Collaborator Author

reta commented Dec 13, 2021

@dblock we could, yeah, will send the PR shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x pending backport Identifies an issue or PR that still needs to be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants