-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix saved queries for 3rd-party plugins by honoring wildcard supportedAppName #10973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix saved queries for 3rd-party plugins by honoring wildcard supportedAppName #10973
Conversation
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
69895fc to
4aac7ad
Compare
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
…dAppName (fixes opensearch-project#10972) Signed-off-by: Thilo-Alexander Ginkel <[email protected]>
4aac7ad to
aa5129b
Compare
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
1 similar comment
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10973 +/- ##
=======================================
Coverage 60.78% 60.79%
=======================================
Files 4531 4531
Lines 122258 122258
Branches 20498 20497 -1
=======================================
+ Hits 74317 74324 +7
+ Misses 42696 42691 -5
+ Partials 5245 5243 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This PR brings back Saved Queries to 3rd-party plugins
Issues Resolved
fixes #10972
Screenshot
(after the fix)
Testing the changes
The fix can be most easily tested by creating a global saved query from a third-party plugin or a plugin that does not explicitly appear in the allowlist at https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/data/public/query/query_string/language_service/lib/dql_language.ts#L34. Without the fix, the Saved Queries Flyout will remain empty, with the fix applied it will show the saved queries.
Changelog
Check List
yarn test:jestyarn test:jest_integrationTests do not pass, but they also don't pass on
main.