Skip to content

Conversation

@ginkel
Copy link
Contributor

@ginkel ginkel commented Nov 25, 2025

Description

This PR brings back Saved Queries to 3rd-party plugins

Issues Resolved

fixes #10972

Screenshot

image

(after the fix)

Testing the changes

The fix can be most easily tested by creating a global saved query from a third-party plugin or a plugin that does not explicitly appear in the allowlist at https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/data/public/query/query_string/language_service/lib/dql_language.ts#L34. Without the fix, the Saved Queries Flyout will remain empty, with the fix applied it will show the saved queries.

Changelog

  • fix: Restore saved queries for 3rd-party plugins by honoring wildcard supportedAppName

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Tests do not pass, but they also don't pass on main.

@github-actions
Copy link
Contributor

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

@ginkel ginkel force-pushed the fix-saved-query-language-filtering branch from 69895fc to 4aac7ad Compare November 25, 2025 18:42
@github-actions
Copy link
Contributor

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

@ginkel ginkel force-pushed the fix-saved-query-language-filtering branch from 4aac7ad to aa5129b Compare November 25, 2025 18:46
@github-actions
Copy link
Contributor

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

1 similar comment
@github-actions
Copy link
Contributor

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.79%. Comparing base (f129a7e) to head (4804d6c).

Files with missing lines Patch % Lines
...ta/public/query/saved_query/saved_query_service.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10973   +/-   ##
=======================================
  Coverage   60.78%   60.79%           
=======================================
  Files        4531     4531           
  Lines      122258   122258           
  Branches    20498    20497    -1     
=======================================
+ Hits        74317    74324    +7     
+ Misses      42696    42691    -5     
+ Partials     5245     5243    -2     
Flag Coverage Δ
Linux_1 26.56% <0.00%> (ø)
Linux_2 38.92% <ø> (ø)
Linux_3 39.50% <0.00%> (ø)
Linux_4 33.73% <0.00%> (ø)
Windows_1 26.57% <0.00%> (ø)
Windows_2 38.90% <ø> (ø)
Windows_3 39.51% <0.00%> (+<0.01%) ⬆️
Windows_4 33.74% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Saved queries are filtered out for 3rd-party plugins

1 participant