-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Support by-value explore embeddables without stored saved object #10970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joshuali925
wants to merge
3
commits into
opensearch-project:main
Choose a base branch
from
joshuali925:by-value-emb
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Li <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10970 +/- ##
==========================================
+ Coverage 60.78% 60.80% +0.01%
==========================================
Files 4531 4531
Lines 122243 122279 +36
Branches 20492 20503 +11
==========================================
+ Hits 74304 74347 +43
+ Misses 42697 42689 -8
- Partials 5242 5243 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ps48
reviewed
Nov 25, 2025
ps48
reviewed
Nov 25, 2025
ps48
previously approved these changes
Nov 25, 2025
Signed-off-by: Joshua Li <[email protected]>
ps48
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support by-value explore embeddables without stored saved object. In previous implementation, we can only render a visualization using saved explore embeddable if the object has been saved. This PR allows providing a JSON input and render it directly, without storing the saved object.
Sample code to use it:
Issues Resolved
Screenshot
Testing the changes
added UT
Changelog
Check List
yarn test:jestyarn test:jest_integration