Improve recipes and excluded them from C# codebase if needed #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jevanlingen
force-pushed
the
exclude-non-usable-cs-recipes
branch
from
ab20d12 to
2d28a34
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/main/java/org/openrewrite/staticanalysis/CaseInsensitiveComparisonsDoNotChangeCase.java
Outdated
Show resolved
Hide resolved
timtebeek
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Some suggestions could not be made:
- src/main/java/org/openrewrite/staticanalysis/FixStringFormatExpressions.java
- lines 29-29
- src/main/java/org/openrewrite/staticanalysis/IndexOfChecksShouldUseAStartPosition.java
- lines 27-27
- src/main/java/org/openrewrite/staticanalysis/IndexOfReplaceableByContains.java
- lines 25-25
- src/main/java/org/openrewrite/staticanalysis/IndexOfShouldNotCompareGreaterThanZero.java
- lines 20-20
- src/main/java/org/openrewrite/staticanalysis/ObjectFinalizeCallsSuper.java
- lines 28-28
- src/main/java/org/openrewrite/staticanalysis/PrimitiveWrapperClassConstructorToValueOf.java
- lines 30-30
- src/main/java/org/openrewrite/staticanalysis/StringLiteralEquality.java
- lines 25-25
- src/main/java/org/openrewrite/staticanalysis/WriteOctalValuesAsDecimal.java
- lines 26-27
src/main/java/org/openrewrite/staticanalysis/NewStringBuilderBufferWithCharArgument.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Some suggestions could not be made:
- src/main/java/org/openrewrite/staticanalysis/FixStringFormatExpressions.java
- lines 29-29
- src/main/java/org/openrewrite/staticanalysis/IndexOfChecksShouldUseAStartPosition.java
- lines 27-27
- src/main/java/org/openrewrite/staticanalysis/IndexOfReplaceableByContains.java
- lines 25-25
- src/main/java/org/openrewrite/staticanalysis/IndexOfShouldNotCompareGreaterThanZero.java
- lines 20-20
- src/main/java/org/openrewrite/staticanalysis/ObjectFinalizeCallsSuper.java
- lines 28-28
- src/main/java/org/openrewrite/staticanalysis/PrimitiveWrapperClassConstructorToValueOf.java
- lines 30-30
- src/main/java/org/openrewrite/staticanalysis/StringLiteralEquality.java
- lines 25-25
- src/main/java/org/openrewrite/staticanalysis/WriteOctalValuesAsDecimal.java
- lines 26-27
There was a problem hiding this comment.
Some suggestions could not be made:
- src/main/java/org/openrewrite/staticanalysis/FixStringFormatExpressions.java
- lines 29-29
- src/main/java/org/openrewrite/staticanalysis/IndexOfChecksShouldUseAStartPosition.java
- lines 27-27
- src/main/java/org/openrewrite/staticanalysis/IndexOfReplaceableByContains.java
- lines 25-25
- src/main/java/org/openrewrite/staticanalysis/IndexOfShouldNotCompareGreaterThanZero.java
- lines 20-20
- src/main/java/org/openrewrite/staticanalysis/ObjectFinalizeCallsSuper.java
- lines 28-28
- src/main/java/org/openrewrite/staticanalysis/PrimitiveWrapperClassConstructorToValueOf.java
- lines 30-30
- src/main/java/org/openrewrite/staticanalysis/StringLiteralEquality.java
- lines 25-25
- src/main/java/org/openrewrite/staticanalysis/WriteOctalValuesAsDecimal.java
- lines 26-27
timtebeek
reviewed
Nov 27, 2024
timtebeek
approved these changes
Nov 27, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ufferWithCharArgument.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jevanlingen
force-pushed
the
exclude-non-usable-cs-recipes
branch
from
68200b7 to
9fc2972
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Excluded CSharp for some recipes + made some recipes a little bit more modern
What's your motivation?
Some recipes don't work for C#.
Checklist