Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMD: LiteralsFirstInComparisons for compareTo* and contentEquals #365

Closed
wants to merge 30 commits into from
Closed

PMD: LiteralsFirstInComparisons for compareTo* and contentEquals #365

wants to merge 30 commits into from

Conversation

punkratz312
Copy link
Contributor

@punkratz312 punkratz312 commented Oct 14, 2024 •
edited by timtebeek
Loading

@punkratz312 punkratz312 marked this pull request as draft October 14, 2024 09:42
@punkratz312 punkratz312 changed the title Equals avoids null visitor extend literalsfirstincomparisons extend PMD: LiteralsFirstInComparisons for compareTo* and contentEquals Oct 14, 2024
@punkratz312 punkratz312 mentioned this pull request Oct 14, 2024
Open
punkratz312
punkratz312 commented Oct 14, 2024
View reviewed changes
build.gradle.kts Outdated Show resolved Hide resolved
timtebeek
timtebeek requested changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see these additions; just a couple of requests to reduce the changes before we merge, to make it easier to review.

build.gradle.kts Outdated Show resolved Hide resolved
src/test/java/org/openrewrite/staticanalysis/EqualsAvoidsNullVisitorTest.java Outdated Show resolved Hide resolved
src/test/java/org/openrewrite/staticanalysis/EqualsAvoidsNullVisitorTest.java Show resolved Hide resolved
src/test/java/org/openrewrite/staticanalysis/EqualsAvoidsNullVisitorTest.java Outdated Show resolved Hide resolved
@timtebeek timtebeek added enhancement New feature or request recipe labels Oct 14, 2024
@punkratz312 punkratz312 marked this pull request as ready for review October 14, 2024 10:46
@punkratz312
Copy link
Contributor Author

#366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtebeek timtebeek timtebeek requested changes

Assignees

@punkratz312 punkratz312

Labels
enhancement New feature or request recipe
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@punkratz312 @timtebeek