silence warning about if guard#18
Open
maage wants to merge 1 commit intoopenresty:masterfrom
Open
Conversation
In file included from src/sregex/sre_vm_thompson_jit.c:16:0: ./dynasm/dasm_x86.h: In function 'dasm_put': ./dynasm/dasm_x86.h:207:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (*p++ == 1 && *p == DASM_DISP) mrm = n; continue; ^~ ./dynasm/dasm_x86.h:207:45: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if' if (*p++ == 1 && *p == DASM_DISP) mrm = n; continue; ^~~~~~~~
Member
|
@maage Maybe we should update the upstream dynasm instead? We simply copied over the dynasm directory of the luajit-2.0 git repository BTW. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gcc 6.1.1 has this warning at Fedora 24.
I'm not quite sure how to fix this right, now patch does fixes the warning and it should do as previously. So this should be just style without functional change.