balancer: Add ngx_http_lua_ffi_balancer_set_ssl_ctx #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 18, 2018
p0pr0ck5
reviewed
Jun 2, 2018
src/ngx_http_lua_balancer.c
Outdated
| SSL_CTX* ssl_ctx, char **err) | ||
| { | ||
| ngx_http_lua_ctx_t *ctx; | ||
| ngx_http_upstream_t *u; |
There was a problem hiding this comment.
Pedantic style: two spaces between ngx_http_upstream_t and *u
There was a problem hiding this comment.
I thought the style was to vertically align ctx and u?
There was a problem hiding this comment.
Based on http://nginx.org/en/docs/dev/development_guide.html#code_style_variables (and it looks like this repo follows this guide), there are two spaces separating the columns (types and names), with the right column left-aligned based on deference operators.
This function allows setting an upstream's SSL_CTX* to a user-provided object
james-callahan
force-pushed
the
balancer_set_ssl_ctx
branch
from
83f7f89
to
e04bb58
Compare
|
This pull request is now in conflict :( |
zhuizhuhaomeng
force-pushed
the
master
branch
from
f924579
to
fef2581
Compare
|
This pull request is now in conflict :( |
|
This pull request is now in conflict :( |
|
This pull request is now in conflict :( |
|
This pull request is now in conflict :( |
|
This pull request is now in conflict :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function allows setting an upstream's
SSL_CTX*to a user-provided objectIt comes with a sister pull-request to lua-resty-core: openresty/lua-resty-core#179
I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.