Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker fat image reduction #228

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sshumov
Copy link

@sshumov sshumov commented Apr 26, 2023

almost 3 times smaller fat images by removing unused alpine packages
original size:
REPOSITORY TAG IMAGE ID CREATED SIZE test latest f3a4fb6875e7 About a minute ago 396MB
fix:
REPOSITORY TAG IMAGE ID CREATED SIZE test-fix-size latest 6034bc75cd29 4 seconds ago 108MB test latest f3a4fb6875e7 2 minutes ago 396MB

@neomantra
Copy link
Member

neomantra commented Apr 26, 2023

Hello, thanks for the contribution. I understand what you are doing -- moving some packages to be auto-removed at the end. I also appreciate the significant size reduction....

But, this is a weird image. It was called fat because it is larger and has those many installed packages. Those weren't necessarily intended to be solely build-dependencies for luarocks itself, but also for many other common packages that seem to be needed by other rocks. It was also intended to be an example of deriving images from the base openresrty image.

I'm weary of changing the included packages. It might affect users who derive FROM it. If a new user is really concerned about size, they can see how to derive an as-slim-as-possible image from these.

However, maybe there is some other new image flavor (meaning like -fat) that is needed? Why/how are you using the fat images?

EDIT TO ADD: Maybe it's more OK to change the -fat contents with a significant tag change, like the forthcoming 1.21.4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants