Upload merged #77
Open
Upload merged #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medihack
reviewed
Jun 24, 2024
tasks.py
Outdated
| @@ -372,6 +387,7 @@ def show_outdated(ctx: Context): | |||
| def upgrade(ctx: Context): | |||
| """Upgrade Python and JS packages""" | |||
| ctx.run("poetry update", pty=True) | |||
| copy_statics(ctx) | |||
There was a problem hiding this comment.
And npm?! Or what are you copying?
| @@ -26,6 +26,7 @@ | |||
| "debug_toolbar", | |||
| "debug_permissions", | |||
| "django_browser_reload", | |||
| "adit.upload.apps.UploadConfig", | |||
adit/core/widgets.py
Outdated
| @@ -13,7 +13,9 @@ def create_option(self, name, value, label, selected, index, subindex=None, attr | |||
| dicom_node = value.instance | |||
| if dicom_node.node_type == DicomNode.NodeType.SERVER: | |||
| option["attrs"]["data-node_type"] = "server" | |||
| option["attrs"]["node_id"] = dicom_node.id | |||
There was a problem hiding this comment.
It's not a valid HTML attribute! Add data-
| expect(poll(page.locator("button#uploadButton"))).to_be_visible() | ||
| expect(poll(page.locator("button#clearButton"))).to_be_visible() | ||
|
|
||
| # page.screenshot(path="./screenshots/before_upload.png") |
There was a problem hiding this comment.
Get rid of all unnecessary comments
adit/upload/static/upload/upload.js
Outdated
| document.getElementById("uploadCompleteText").style.display = "none"; | ||
| }, | ||
| clearFiles: function () { | ||
| var inputEl = document.getElementById("fileselector"); |
adit/upload/static/upload/upload.js
Outdated
| document.getElementById("uploadCompleteText").style.display = | ||
| "inline-block"; | ||
| }, 3000); | ||
| // Wait for 3 seconds (3000 milliseconds) |
There was a problem hiding this comment.
What is the purpose of this comment? It's pretty clear from the code
adit/upload/static/upload/upload.js
Outdated
| "inline-block"; | ||
| } | ||
|
|
||
| console.log("Upload process finished"); |
There was a problem hiding this comment.
Don't use log if you want to leave it in the code. Use info, for example.
adit/upload/static/upload/upload.js
Outdated
| patientBirthdates.size <= 1 | ||
| ); | ||
| } catch (e) { | ||
| //console.log(e); |
adit/upload/static/upload/upload.js
Outdated
| } | ||
| }) | ||
| .catch(function (error) { | ||
| //console.log(`Error: ${error.reason_phrase}`); |
Otherwise all those manage commands would also run multiple times
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.