fix-typedmodels-api

changed titled Fix Typed Model Service Fix Typed Model Controller Update README.md shell commands Co-authored-by: Mihai Diaconeasa <[email protected]> Merge-request: OPENPRA-MR-39 Merged-by: Arjun Earthperson <[email protected]>
openpra-org · Dec 17, 2023 · e1207cd · e1207cd
1 parent a488e21
commit e1207cd
Show file tree

Hide file tree

Showing 3 changed files with 75 additions and 59 deletions.
diff --git a/README.md b/README.md
@@ -1,4 +1,4 @@
-# OpenPRA Monorepo
+# OpenPRA MonoRepo
 
 Welcome to the OpenPRA Monorepo, the unified codebase for
 the [OpenPRA application suite](https://docs.openpra.org/).
@@ -214,17 +214,32 @@ packages, follow these general steps:
 
 You can always use the command line to serve or build any of the targets. `nx`
 supports a wide range of commands, so be
-sure to check out its documentation. Some very basic examples include:
+sure to check out its documentation.
 
+Some very basic examples include:
+
+ - Serve packages concurrently
+```shell
+nx run-many -t serve --all
+```
+
+ - Serve packages individually:
 ```shell
 nx serve web-editor
+```
+```shell
 nx serve web-backend
+```
+```shell
+nx serve shared-types
+```
 
-# alternatively, serve all concurrently:
-nx run-many -t serve --all
-
-# run Jest unit tests and linting across the project with:
+ - Run Jest unit tests and linting across the project with:
+```shell
 nx run-many -t test
+```
+ - Run ES linting across the project with:
+```shell
 nx run-many -t lint
 ```
 

diff --git a/packages/web-backend/src/typedModel/typedModel.controller.ts b/packages/web-backend/src/typedModel/typedModel.controller.ts
@@ -13,10 +13,10 @@ import {
   HttpStatus,
 } from "@nestjs/common";
 import { AuthGuard } from "@nestjs/passport";
-import InternalEventsModel from "shared-types/src/lib/types/modelTypes/largeModels/internalEventsModel";
-import ExternalEventsModel from "shared-types/src/lib/types/modelTypes/largeModels/externalHazardsModel";
-import InternalHazardsModel from "shared-types/src/lib/types/modelTypes/largeModels/internalHazardsModel";
-import FullScopeModel from "shared-types/src/lib/types/modelTypes/largeModels/fullScopeModel";
+import {InternalEventsModel} from "shared-types/src/lib/types/modelTypes/largeModels/internalEventsModel";
+import {InternalHazardsModel} from "shared-types/src/lib/types/modelTypes/largeModels/internalHazardsModel";
+import {FullScopeModel} from "shared-types/src/lib/types/modelTypes/largeModels/fullScopeModel";
+import {ExternalHazardsModel} from "shared-types/src/lib/types/modelTypes/largeModels/externalHazardsModel";
 import { InvalidTokenFilter } from "../filters/invalid-token.filter";
 import { TypedModelService } from "./typedModel.service";
 import { InternalEvents } from "./schemas/internal-events.schema";
@@ -293,7 +293,7 @@ export class TypedModelController {
   async deleteExternalHazard(
     @Request() req,
     @Query("modelId") modelId: string,
-  ): Promise<ExternalEventsModel> {
+  ): Promise<ExternalHazardsModel> {
     return this.typedModelService.deleteExternalHazard(
       Number(modelId),
       req.user.user_id,