-
Notifications
You must be signed in to change notification settings - Fork 38
[Blocked by release] docs(cloudflare): skew protection #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0844a9f
to
f69fdf5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
<Callout type="info"> | ||
Preview URLs are disabled for [Workers that implement a Durable | ||
Object](https://developers.cloudflare.com/workers/configuration/previews/#limitations). If your app uses | ||
Durable Objects, they will need to be implemented in a separate Worker. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably add an example for this at one point.
f69fdf5
to
8719e57
Compare
Updated the PR to sync with the skew protection PR and add details about serving assets |
|
||
The following environment variables should be set when the skew protection is used: | ||
|
||
- `CF_WORKER_NAME` should be set to the name of the worker, i.e. `my-app` given the config above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- `CF_WORKER_NAME` should be set to the name of the worker, i.e. `my-app` given the config above | |
- `CF_WORKER_NAME` should be set to the name of the worker, i.e. `my-app` given the config above. If you're using environment, the name of the app should contain your env, i.e. `my-app-<env>` |
- Because the Worker is configured to run in front of the assets Worker (`run_worker_first`), requesting an asset will count as a request to your Worker | ||
- Requesting an older deployment will generate 2 requests: the request to the latest version and the request to the older version | ||
- It is not currently possible to delete a deployment | ||
- Requests to an older deployement will be a few milli-seconds slower than requests to the latest version of the app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Requests to an older deployement will be a few milli-seconds slower than requests to the latest version of the app | |
- Requests to an older deployment will be a few milli-seconds slower than requests to the latest version of the app | |
- Request to a deployment older than the `maxNumberOfVersions` or older than `maxVersionAgeDays` will fallback to the current deployment |
The implementation is at opennextjs/opennextjs-cloudflare#746 for the implementation