-
Notifications
You must be signed in to change notification settings - Fork 38
[Blocked by release] docs(cloudflare): skew protection #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0844a9f
to
f69fdf5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
<Callout type="info"> | ||
Preview URLs are disabled for [Workers that implement a Durable | ||
Object](https://developers.cloudflare.com/workers/configuration/previews/#limitations). If your app uses | ||
Durable Objects, they will need to be implemented in a separate Worker. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably add an example for this at one point.
f69fdf5
to
8719e57
Compare
Updated the PR to sync with the skew protection PR and add details about serving assets |
Co-authored-by: conico974 <[email protected]>
Co-authored-by: conico974 <[email protected]>
|
||
**Wrangler configuration** | ||
|
||
The Worker needs to serve the correct version of the app assets. For that it need be be executed before incoming requests are matched against the assets. Set [`run_worker_first`](https://developers.cloudflare.com/workers/static-assets/binding/#run_worker_first) to `tue` in your wrangler configuration to enable this behavior: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Worker needs to serve the correct version of the app assets. For that it need be be executed before incoming requests are matched against the assets. Set [`run_worker_first`](https://developers.cloudflare.com/workers/static-assets/binding/#run_worker_first) to `tue` in your wrangler configuration to enable this behavior: | |
The Worker needs to serve the correct version of the app assets. For that it need be be executed before incoming requests are matched against the assets. Set [`run_worker_first`](https://developers.cloudflare.com/workers/static-assets/binding/#run_worker_first) to `true` in your wrangler configuration to enable this behavior: |
The implementation is at opennextjs/opennextjs-cloudflare#746 for the implementation