O3-3640: SDK to use any content packages specified in distribution properties #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6052404.
|
@ibacher , could you take a look at this PR? |
ibacher
requested changes
Sep 19, 2024
maven-plugin/src/main/java/org/openmrs/maven/plugins/BuildDistro.java
Outdated
Show resolved
Hide resolved
maven-plugin/src/main/java/org/openmrs/maven/plugins/BuildDistro.java
Outdated
Show resolved
Hide resolved
maven-plugin/src/main/java/org/openmrs/maven/plugins/BuildDistro.java
Outdated
Show resolved
Hide resolved
maven-plugin/src/main/java/org/openmrs/maven/plugins/utility/ContentHelper.java
Outdated
Show resolved
Hide resolved
maven-plugin/src/main/java/org/openmrs/maven/plugins/Setup.java
Outdated
Show resolved
Hide resolved
maven-plugin/src/main/java/org/openmrs/maven/plugins/utility/ContentHelper.java
Outdated
Show resolved
Hide resolved
maven-plugin/src/main/java/org/openmrs/maven/plugins/utility/ModuleInstaller.java
Outdated
Show resolved
Hide resolved
sdk-commons/src/main/java/org/openmrs/maven/plugins/model/BaseSdkProperties.java
Outdated
Show resolved
Hide resolved
sdk-commons/src/main/java/org/openmrs/maven/plugins/model/BaseSdkProperties.java
Outdated
Show resolved
Hide resolved
…into O3-3640-new
ibacher
changed the title
ibacher
changed the title
ibacher
approved these changes
Sep 24, 2024
|
Thank you for the improvements and Merging and closing the PR. so happy its Merged and closed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to handle content packages
Issue I worked on
https://openmrs.atlassian.net/browse/O3-3640
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
This causes issue as the existing code uses some convention other than OpenMRS_Formatter, i had to disable formatting on save actions and manually format the new code
I ran
mvn clean installright before creating this pull request andadded all formatting changes to my commit.
All existing tests passed.
My pull request is based on the latest changes of the master branch.
P.S Additionally, ran setup and build-distro with and without the content.hiv entry in the distro properties file.
09/19 -
