-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) O3-4044 Ward App - use vertical tiling for ward patient cards #1377
Open
chibongho
wants to merge
1
commit into
main
Choose a base branch
from
O3-4044
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -248 B (0%) Total Size: 6.68 MB ℹ️ View Unchanged
|
mogoodrich
approved these changes
Nov 15, 2024
denniskigen
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Previously, vertical tiling mode for ward patient cards was behind a feature flag. The ward view scrolls vertically when there is not enough screen space to display the cards. Feedback from both PIH team and UX designers seems positive on it, so I'm just going to enable it.
Screenshots
Ward with many beds + patients. The ward view uses vertical scrolling.
Ward with few beds + patients. Note that the tiling mode prefers roughly even height for each column, so in this case, the tiling actually appears horizontal.
Related Issue
https://openmrs.atlassian.net/browse/O3-4044
Other