(fix) O3-4116 use correct colours for service queue priority #1376
+51
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
(First PR here so please let me know if I'm doing something wrong)
O3-4116 notes that priority tags in the service queue view don't have any color.
Implementers were already able to configure this, however this was probably not used frequently. So I'm guessing the intended behaviour is a default configuration that can be overwritten if necessary. This is what this PR adds.
The PR also adds support for the orange color intended for the 'urgent' priority that was still missing.
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-4116
Other
I'm not very happy the way the orange color is handled: Seems like the carbon design system does not have a color 'orange' so I implemented it as a special case similar to how the tags for the header in the patient-chart are implemented. I'm also hardcoding the same color. This seems to be slightly smelly. I'm guessing this component in this color is used in a few different places so there should be a generic solution for this problem but I'm not sure how to approach it... Suggestions welcome!
Also, the issue also asks for fixing capitalization for 'Not Urgent' - I haven't looked into this yet so might be another PR