(refactor) Various tweaks to the MPI workflow #1374
+173
−156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +418 B (+0.01%) Total Size: 6.68 MB ℹ️ View Unchanged
|
denniskigen
changed the title
denniskigen
commented
Nov 14, 2024
| error: error, | ||
| isLoading: isLoading, | ||
| } = useSWR<{ data: fhir.Patient }, Error>(url, openmrsFetch); | ||
| const { data, error, isLoading } = useSWR<{ data: fhir.Patient }, Error>(url, openmrsFetch); |
There was a problem hiding this comment.
The main change here is that instead of returning the whole patient object and requiring consumers of the hook to use patient.data to access the actual FHIR Patient resource, we unwrap the FHIR patient resource directly and return it as the mpiPatient variable.
Comment on lines
+133
to
+137
| fieldConfigurations.identifier, | ||
| fieldConfigurations.phone.personAttributeUuid, | ||
| initialFormValues, | ||
| isLoadingMpiPatient, | ||
| mpiPatient, |
There was a problem hiding this comment.
This adds missing dependencies to the effect hook. I don't know why the exhaustive-deps eslint rule is not enabled for this repo. It should be so we can catch subtle bugs related to violations of rules of hooks.
| </Routes> | ||
| </MemoryRouter>, | ||
| ); | ||
| renderWithRouter(<PatientSearchButton />); |
There was a problem hiding this comment.
Refactored to use the custom renderWithRouter wrapper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR provides several tweaks to support #1313.
Screenshots
Both adapted to align with this design.
Empty state from search with button to trigger MPI lookup
Error state tile for MPI lookup
Related Issue
Other