Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make passing user supplied partial charges to SystemGenerator an explicit keyword? #296

Open
IAlibay opened this issue Aug 16, 2023 · 1 comment

Comments

@IAlibay
Copy link

IAlibay commented Aug 16, 2023

Currently SystemGenerator does the following:

  • If there are partial charges present on the OFF molecule use them directly (i.e. don't generate new charges)
  • Unless these partial charges are zeroed, in which case silently re-generate them.

From recent discussions (alchemiscale meeting ~ month ago) it seems like folks are a bit wary about the idea of this being done silently. Indeed the latter behaviour caught me out whilst I was trying to debug something else lately.

Would folks be interested in either:

  • Making using pre-defined charges something you need to pass an explicit kwarg for?
  • Being rather noisy about what's going on (something higher level than logger.debug)?
@ijpulidos
Copy link
Collaborator

ijpulidos commented Aug 17, 2023

I think this is something that have been somewhat discussed in the past in #282 (comment) The concern here is that it could break the API

I'm okay with either approach, but I agree that we should probably make this clearer in the logging for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants