-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow kwargs to be passed to force field generators (and then to SMIRNOFF ForceField) #112
Comments
Oh, my! I never considered providing a mechanism to pass arguments to Out of curiosity, why would you have non-integral charges? |
@jchodera why do I have non-integral charges.... ask neural networks. Not sure why that happens. My guess is something gets messed up somewhere. I knew someone would ask when I posted, but I would guess this change would be useful for something relevant as well haha |
You might check out this simple idea in which you ask the ML model to predict two physical parameters (electronegativity and hardness) per atom, and then solve a simple convex optimization problem inspired by a physical charge-equilibration model to determine the (integral) charges. In our hands, this works much better than trying to get the ML model to learn the integral charge constraint! |
A mechanism for this has been added for the |
#296 related, if I understand both accurately |
It seems forcefield_kwargs is not being propagated sometimes. I've fixed this error below by editing
to
as a hack-y fix.
This is the error I typically get without the fix
The text was updated successfully, but these errors were encountered: