chore: customer list tweaks

[turip]

Overview

This approach allows us to use the ListCustomers internally without having to deal with the Page schemantics.

Summary by CodeRabbit

• New Features

  • Added a validation check to ensure customer requests include the required namespace, providing immediate feedback on missing inputs.

• Refactor

  • Removed explicit pagination handling from customer data retrieval processes, streamlining behavior.
  • Enhanced error checking on pagination parameters to catch issues early during customer listing requests.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes update how customer data is processed. Two files have had their pagination integration removed, eliminating both the pagination package import and the initialization of pagination objects. A new validation method is also added to ensure that a mandatory field is not empty in customer inputs. In addition, an extra validation step was introduced in the HTTP handler to verify the pagination page field before further processing.

Changes

File(s)	Change Summary
openmeter/app/.../stripe.go openmeter/productcatalog/.../create.go	Removed pagination import and deleted initialization (pagination.NewPage(1, 1)) in customer listing calls.
openmeter/customer/customer.go	Added a Validate method to ListCustomersInput to enforce that the Namespace field is not empty.
openmeter/customer/httpdriver/customer.go	Added a validation check for the pagination Page field in the ListCustomers handler to capture errors early.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 55556d1 and 8e0d189.

📒 Files selected for processing (4)

• openmeter/app/stripe/adapter/stripe.go (0 hunks)
• openmeter/customer/customer.go (1 hunks)
• openmeter/customer/httpdriver/customer.go (1 hunks)
• openmeter/productcatalog/subscription/service/create.go (0 hunks)

💤 Files with no reviewable changes (2)

• openmeter/productcatalog/subscription/service/create.go
• openmeter/app/stripe/adapter/stripe.go

🔇 Additional comments (2)

openmeter/customer/customer.go (1)

122-128: LGTM! Good addition of validation for ListCustomersInput.

The new Validate method ensures that the Namespace field is not empty, which aligns with the PR objective of improving internal usage of ListCustomers functionality. This validation will prevent issues that could arise from attempting to list customers without specifying a namespace.

openmeter/customer/httpdriver/customer.go (1)

61-63:

✅ Verification successful

Good addition of page validation.

This validation step ensures that the pagination parameters are valid before proceeding with the request, which is in line with the PR objective of improving the internal usage of ListCustomers. The error handling is consistent with other error handling in the function.

---

🏁 Script executed:

#!/bin/bash
# Check if the Page.Validate() method exists in the pagination package
cat pkg/pagination/pagination.go 2>/dev/null || echo "Pagination file not found at expected location"

# Find any uses of ListCustomers to understand how it's used internally
rg "ListCustomers" --type go -A 3 -B 3

Length of output: 24867

---

Approval: Page Validation Verified

The added validation using req.Page.Validate() correctly ensures that invalid pagination parameters are caught early in the ListCustomers handler. This implementation aligns with our pagination package validation criteria and is consistent with error handling throughout the function.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.