chore: date calculation research #2376
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turip
commented
Mar 4, 2025
| @@ -0,0 +1,128 @@ | |||
| # intro | |||
|
|
|||
| Dump of test case outputs. | |||
There was a problem hiding this comment.
@hekike please validate if this is the expected output
|
|
||
| ## Daylight savings changes - anchor has timezone information | ||
|
|
||
| Anchor: `2025-02-01T13:00:00+01:00` (BP Time) |
There was a problem hiding this comment.
Right now we are storing all times in UTC. @hekike don't we want to make an exception in case of anchors to store the tz information in the DB.
The anchor's tz information is crucial to preserve timestamps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #(issue)
Notes for reviewer