Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: line updating #1905

Merged
merged 4 commits into from
Nov 27, 2024
Merged

feat: line updating #1905

merged 4 commits into from
Nov 27, 2024

Conversation

turip
Copy link
Contributor

@turip turip commented Nov 22, 2024

Overview

This patch adds support for updating lines. This paves the way for line deletion.

Mayjor changes:

  • Calculator can recalculate the whole invoice
  • WithTransactingRepo is moved to adapter level so that we have less dependencies on service level
  • All changes advance the invoice as much as possible
  • InvoiceLine update operation becomes PUT as we cannot properly support PATCH on union types for now
  • Add entity level support for ValidationError
  • Add support for persisting the prePeriodQTY for Usage based prices
  • Add support for validating updates in terms of billable period

Base automatically changed from feat/billing-api to main November 22, 2024 19:01
@turip turip force-pushed the feat/line-ops branch 3 times, most recently from 2d346e5 to b7b02df Compare November 26, 2024 20:04
@turip turip changed the title feat: line ops feat: line updating Nov 26, 2024
@turip turip added release-note/feature Release note: Exciting New Features area/billing labels Nov 26, 2024
This patch adds support to calls that we already support.
This patch:
- Reverts all API changes as that will be done in a seperate PR
- Gets rid of the conflict handling and the funky UpdatedAt logic
@turip turip marked this pull request as ready for review November 27, 2024 14:01
@turip turip merged commit e16fe3d into main Nov 27, 2024
24 checks passed
@turip turip deleted the feat/line-ops branch November 27, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/billing release-note/feature Release note: Exciting New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants