-
Notifications
You must be signed in to change notification settings - Fork 551
Source biasing capabilities #3460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
j-fletcher
wants to merge
20
commits into
openmc-dev:develop
Choose a base branch
from
j-fletcher:source_bias
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in Python. Added bias, Sample object and XML reading on cpp.
…emoved function fragment from DiscreteIndex.
…implementation for Distribution::evaluate()
…; added missing dereference for sampling distributions in PolarAzimuthal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds capability to bias univariate and multivariate distributions for source biasing. This capability will ultimately be useful for the addition of automated CADIS weight-windowing using the adjoint random ray solver.
For some probability density function$p(x)$ , a bias distribution $b(x)$ may be specified which more frequently samples the phase space region(s) of interest, provided supp $(p) =$ supp $(b)$ . Each sample $x_0$ drawn from $b(x)$ is then weighted according to $\frac{p(x_0)}{b(x_0)}$ .
This PR adds a
bias
attribute to eachUnivariate
distribution, with the exception ofMixture
. Thebias
attribute can be any univariate distribution, althoughDiscrete
distributions may only be biased by anotherDiscrete
with the same number of elements. An error is raised if a bias distribution is itself biased by another distribution; eventually this process will also verify whether the parent and bias distributions share common support.Likewise, multivariate independent distributions (
PolarAzimuthal
,CartesianIndependent
,SphericalIndependent
,CylindricalIndependent
) can be biased by applying a bias distribution to any of their constituent distributions. Similarly,MeshSpatial
andPointCloud
can be biased by specifying a second vector of strengths, which achieves the same effect as a biasedDiscrete
.Isotropic
, however, is biased by aPolarAzimuthal
, andMonodirectional
andPoint
may not be biased.Below is an example of creating two biased distributions.
This PR does introduce a major change in that sampling these distributions will now return a weight along with the usual sample type. Where available, in Python this will be a tuple of the sample and weight, while in C++, sampling returns a
std::pair
of the usual return type (e.g.Position
,Direction
, ordouble
) and its associated weight (adouble
). If no bias distribution is specified, analog sampling will occur and return unit weight. Documentation and tests are pending for this change.Checklist