Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added stable and unstable nuclides to the Chain object #3338

Merged

Conversation

shimwell
Copy link
Member

@shimwell shimwell commented Mar 6, 2025

Description

I find myself wanting to access the stable and unstable nuclides in a chain file when post processing results. Perhaps this is functionality useful for others. It doesn't save much effort but could perhaps still be useful. I tend to filter the material isotopes to see which nuclides produced are unstable, then I further filter by activation, decay heat etc when producing plots of important isotopes in activated material as a function of time.

I was not sure if it is best to return a list of Nuclides or list of strings (nuclides names) but I went for the list of nuclides as the Chain.Nuclies also returns a list of openmc.deplete.Nuclide

Fixes # (issue)

Checklist

  • I have performed a self-review of my own code
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@shimwell shimwell requested a review from paulromano as a code owner March 6, 2025 09:34
Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shimwell. I changed them each of them to a @property. Is that cool with you?

@shimwell
Copy link
Member Author

shimwell commented Mar 6, 2025

That is certainly cool with me. Thanks

@shimwell shimwell enabled auto-merge (squash) March 6, 2025 15:04
@shimwell
Copy link
Member Author

shimwell commented Mar 6, 2025

Enabled auto merge

@shimwell shimwell merged commit e360cb4 into openmc-dev:develop Mar 6, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants