Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8344541: [lworld] jdk/tools/sincechecker/modules/java_base/CheckSince_javaBase.java finds "@since" version errors #1312

Open
wants to merge 2 commits into
base: lworld
Choose a base branch
from

Conversation

MrSimms
Copy link
Member

@MrSimms MrSimms commented Nov 27, 2024

Added --ignoreSince <string> option to SinceChecker to allow the project keep using the token "Valhalla" as since version until integration time, at which point, a simple replace @since Valhalla with the appropriate version.

This also requires new API to use the since tag, since the checker still requires it (even if its just a token).


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8344541: [lworld] jdk/tools/sincechecker/modules/java_base/CheckSince_javaBase.java finds "@since" version errors (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1312/head:pull/1312
$ git checkout pull/1312

Update a local copy of the PR:
$ git checkout pull/1312
$ git pull https://git.openjdk.org/valhalla.git pull/1312/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1312

View PR using the GUI difftool:
$ git pr show -t 1312

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1312.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 27, 2024

👋 Welcome back dsimms! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 27, 2024

@MrSimms This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344541: [lworld] jdk/tools/sincechecker/modules/java_base/CheckSince_javaBase.java finds "@since" version errors

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented Nov 27, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant