8344541: [lworld] jdk/tools/sincechecker/modules/java_base/CheckSince_javaBase.java finds "@since" version errors #1312
+29
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
--ignoreSince <string>
option to SinceChecker to allow the project keep using the token "Valhalla" assince
version until integration time, at which point, a simple replace@since Valhalla
with the appropriate version.This also requires new API to use the since tag, since the checker still requires it (even if its just a token).
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1312/head:pull/1312
$ git checkout pull/1312
Update a local copy of the PR:
$ git checkout pull/1312
$ git pull https://git.openjdk.org/valhalla.git pull/1312/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1312
View PR using the GUI difftool:
$ git pr show -t 1312
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1312.diff
Using Webrev
Link to Webrev Comment