Skip to content

8371: Stacktrace should hide hidden frames #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Suchitainf
Copy link
Collaborator

@Suchitainf Suchitainf commented Mar 25, 2025

JFR tool is hiding all the hidden frames. But in JMC, Stacktrace view is still showing lot of hidden methods which is not required from the users point of view. Hence, we will be hiding all the hidden frames as part of this enhancement.

Also, we have updated some test cases also in order to get rid of hidden frames which were expected by the test cases.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8371: Stacktrace should hide hidden frames (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/632/head:pull/632
$ git checkout pull/632

Update a local copy of the PR:
$ git checkout pull/632
$ git pull https://git.openjdk.org/jmc.git pull/632/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 632

View PR using the GUI difftool:
$ git pr show -t 632

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/632.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 25, 2025

👋 Welcome back schaturvedi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 25, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr label Mar 25, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 25, 2025

Webrevs

@egahlin
Copy link
Member

egahlin commented Mar 25, 2025

  • Shouldn't this be something you enable/disable in a preferences dialog?
  • Allocating an ArrayList every time a frame is requested seems unnecessary.
  • What about the time complexity of iterating through a stack trace? Isn't this now O(n^2) instead of O(n)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants