Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8335218: Eclipse Config: Remove Gradle Integration #1491

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

andy-goryachev-oracle
Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle commented Jun 26, 2024

This might be controversial. I am proposing to remove the Gradle integration in the Eclipse config files.

Problem

Eclipse Gradle integration (Buildship) cannot import the OpenJFX build.gradle cleanly. Every time the project is imported into a new workspace (or re-opened after being closed) it executes Gradle, creates and modifies a number of Eclipse .project and .classpath files, all of which need to be reverted for Eclipse workspace to become usable again.

Solution

Remove Gradle nature from the Eclipse project files. This change only affects Eclipse config files and does not impact build.gradle or other IDEs.

Advantages

  1. The multiple nested projects in the repo will get imported cleanly on the first attempt, will not require additional steps to clear the Buildship changes.
  2. completely removes the dependency on the Eclipse Buildship and its idiosyncrasies.

NOTES:

  • even though the reverse was done for IntelliJ, but its gradle import still does not import tests cleanly, see JDK-8223373
  • this improvement contradicts JDK-8223374 as without Eclipse files in the repo, it will be impossible to use Eclipse in a meaningful way without the fully functional Buildship support, and that is a big IF.
  • once integrated, Eclipse users would only need to re-import the main project with 'search for nested projects' enabled

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8335218: Eclipse Config: Remove Gradle Integration (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1491/head:pull/1491
$ git checkout pull/1491

Update a local copy of the PR:
$ git checkout pull/1491
$ git pull https://git.openjdk.org/jfx.git pull/1491/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1491

View PR using the GUI difftool:
$ git pr show -t 1491

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1491.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 26, 2024

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 26, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@andy-goryachev-oracle andy-goryachev-oracle marked this pull request as ready for review June 26, 2024 21:47
@openjdk openjdk bot added the rfr Ready for review label Jun 26, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 26, 2024

Webrevs

@kevinrushforth
Copy link
Member

Reviewers: @nlisker

This will need discussion among and review by the Eclipse users on the list.

/reviewers 2

@openjdk
Copy link

openjdk bot commented Jun 26, 2024

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Ready for review
2 participants