Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8334674: Test new PNG file #1478

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jun 20, 2024

This is a test of the "binary" check. It should warn if the PR includes a binary file.

THIS PR WILL NEVER BE INTEGRATED


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Too few reviewers with at least role reviewer found (have 0, need at least 1) (failed with updated jcheck configuration in pull request)

Warnings

 ⚠️ Patch contains a binary file (apps/HelloWebView.png)
 ⚠️ Patch contains a binary file (apps/HelloWebView.png) (failed with updated jcheck configuration in pull request)

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1478/head:pull/1478
$ git checkout pull/1478

Update a local copy of the PR:
$ git checkout pull/1478
$ git pull https://git.openjdk.org/jfx.git pull/1478/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1478

View PR using the GUI difftool:
$ git pr show -t 1478

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1478.diff

Additional issue: 8334656: Enable issuestitle check
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 20, 2024

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 20, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@kevinrushforth kevinrushforth mentioned this pull request Jun 21, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant