-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8332222: Linux Debian: Maximized stage shrinks when opening another stage #1460
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back tsayao! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
Webrevs
|
I was checking if this fix resolves the issue reported in JDK-8332352 and found that this fix is causing change of behaviour in Ubuntu with KDE desktop environment. |
Screen recording of the above issue video1963044341.mp4 |
I think the mouse behavior is expected, since there is a pointer grab on popups. But the location was wrong. It's fixed now. |
The linux build seems to be failing because the lack of gcc-13 package. |
@tsayao the Ubuntu runner uses now 24.0.4. Your branch just needs to be synced with head. |
@jperedadnr Thanks. @karthikpandelu I tested the sample with the Debian 12 VM and it seems to work now. Would you re-test? |
I can confirm that this now fixes the issue in Ubuntu with KDE desktop environment. |
Can someone kindly review it? |
Reviewers: @arapte @lukostyra /reviewers 2 |
@kevinrushforth |
Initial comments:
Please update both PR and the ticket(s). |
Question. I see different behavior between macOS and linux mint with the attached program (unmodified master branch). On mac, the alert window is always positioned at the upper left corner, while on linux it is correctly placed at the center of the screen. Is this expected? Also on mac, as I understand it, there is no "maximized" state, only full screen. So when the alert window comes up, the main window slides out of view and all we see is the black screen and alert widow at the upper left corner. Unless we move the main window to another monitor. In that case I can see a number of differences:
I feel this behavior (on mac) is unexpected. Any ideas? |
on linux mint, the positioning of the alert window in the case of two screens is the same as on mac, so it looks like it works "as designed". |
If there are bugs on macOS, then I'd file a separate bug, since this bug is only about Linux behavior.
There is a maximized state on macOS. You can enter/exit maximized state programmatically, or by double-clicking on the title bar. |
I don't see any difference with or without this fix on linux mint (I think it's running its own desktop env., different from KDE - how can I tell?). |
The issue 8332222 is KDE specific. When a The fix is around the |
@andy-goryachev-oracle Thanks for looking at Linux issues :)
|
I've tested a bit more on linux mint (not a KDE desktop), see no ill effects. There were a couple of warnings opening modal and regular windows, but the same warnings are present in the master branch. For completeness sake, here they are: Color picker -> custom color -> use? tools -> FxTextArea Embedded in JFXPanel |
This fixes two bugs appointed on the JBS issue:
gdk_window_get_origin
when used before map (a X concept when the window appears). The change is to ignore the configure events (happens when location or size changes) until window is mapped. Before map java is notified in theset_bounds
function.This seems to happen on newer versions of linux distros.
set_enabled
false
on the child (or all other windows if APPLICATION_MODAL) which causes it to update the window constraints. When maximized, the constraints where applied anyways, causing the window to still be maximized but not show as maximized. The change is to not apply constraints when not floating (meaning floating on the screen - not maximized, fullscreen or iconified).Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1460/head:pull/1460
$ git checkout pull/1460
Update a local copy of the PR:
$ git checkout pull/1460
$ git pull https://git.openjdk.org/jfx.git pull/1460/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1460
View PR using the GUI difftool:
$ git pr show -t 1460
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1460.diff
Webrev
Link to Webrev Comment