Skip to content

Conversation

antonvoznia
Copy link

@antonvoznia antonvoznia commented Sep 23, 2025

Hi,

It's a clean backport of JDK-8351359.
I didn't include #include <sysinfoapi.h> as it is in the original commit because of compilation problem.
Instead of that, there is already included windows.h that contains the GetTickCount64() function. It's redundant to include sysinfoapi.h.
The changes are related to Windows only.

Testing:

  • manual testing code that calls getProcessCpuLoad() on windows server 2025, intel cpu
  • testing x86 and x64 builds
  • Pre-submit tests

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8351359 needs maintainer approval
  • Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Issue

  • JDK-8351359: OperatingSystemMXBean: values from getCpuLoad and getProcessCpuLoad are stale after 24.8 days (Windows) (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/701/head:pull/701
$ git checkout pull/701

Update a local copy of the PR:
$ git checkout pull/701
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/701/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 701

View PR using the GUI difftool:
$ git pr show -t 701

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/701.diff

kevinjwalls and others added 2 commits September 22, 2025 15:58
…CpuLoad are stale after 24.8 days (Windows)

Reviewed-by: amenkov, sspitsyn
@antonvoznia antonvoznia changed the title Jdk 8351359 Backport 900b3ff7ee933520efe2438fb7c841a4e6a93d17 Sep 23, 2025
@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Sep 23, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 23, 2025

Hi @antonvoznia, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user antonvoznia" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Sep 23, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 900b3ff7ee933520efe2438fb7c841a4e6a93d17 8351359: OperatingSystemMXBean: values from getCpuLoad and getProcessCpuLoad are stale after 24.8 days (Windows) Sep 23, 2025
@openjdk
Copy link

openjdk bot commented Sep 23, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base oca Needs verification of OCA signatory status
Development

Successfully merging this pull request may close these issues.

2 participants