8373239: Test java/awt/print/PrinterJob/PageRanges.java fails with incorrect selection of printed pages

[rm-gh-8]

Backporting JDK-8373239: Test java/awt/print/PrinterJob/PageRanges.java fails with incorrect selection of printed pages.

This PR fixes a bug in WPrinterJob on Windows where switching from a page range selection back to "All Pages" in the print dialog failed to clear the previously set PageRanges attribute, causing the old range to persist.

For parity with Oracle JDK.

Ran related tests on windows-x64:

jtreg -jdk build/windows-x86_64-server-fastdebug/images/jdk -m test/jdk/java/awt/print/PrinterJob/PageRanges.java

Screenshot:

Result:

test result: Passed. Execution successful

PageRanges.jtr.txt

1.pdf
2.pdf

---

Progress

• Change must not contain extraneous whitespace
• JDK-8373239 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8373239: Test java/awt/print/PrinterJob/PageRanges.java fails with incorrect selection of printed pages (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/423/head:pull/423
$ git checkout pull/423

Update a local copy of the PR:
$ git checkout pull/423
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/423/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 423

View PR using the GUI difftool:
$ git pr show -t 423

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/423.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373239: Test java/awt/print/PrinterJob/PageRanges.java fails with incorrect selection of printed pages

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

• 5d157d5: 8341735: Rewrite the build/AbsPathsInImage.java test to not load the entire file at once
• f8c6ad2: 8378727: [macOS] Missing dispatch_release for semaphores in CDesktopPeer
• dc01cec: 8366695: Test sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java timed out
• ... and 33 more: https://git.openjdk.org/jdk25u-dev/compare/622fb19106ed6647807d910538a18a308f6c6cc4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[rm-gh-8]

/approval request for backport of JDK-8373239: Test java/awt/print/PrinterJob/PageRanges.java fails with incorrect selection of printed pages.

This PR fixes a bug in WPrinterJob on Windows where switching from a page range selection back to "All Pages" in the print dialog failed to clear the previously set PageRanges attribute, causing the old range to persist.

For parity with Oracle JDK.

Low risk — the fix is a minimal, well-scoped else branch in a Windows-only print path that restores the expected "All Pages" behavior

[openjdk]

@rm-gh-8
8373239: The approval request has been created successfully.

[mlbridge]

Webrevs

• 00: Full (a8b33b9a)

[GoeLin]

Hi @rm-gh-8
please also backport the follow-up JDK-8378417 so they can be pushed together.

[rm-gh-8]

@GoeLin JDK-8378417 depends on 2 non-overlapping commits (JDK-8373239 and JDK-8363889). I was planning to merge JDK-8373239 first, then make JDK-8378417 a dependent PR of JDK-8363889. Does this strategy work for you?

[rm-gh-8]

/integrate

[openjdk]

Going to push as commit f18c87f.
Since your change was applied there have been 37 commits pushed to the master branch:

• b4dd845: 8367949: JFR: MethodTrace double-counts methods that catch their own exceptions
• 5d157d5: 8341735: Rewrite the build/AbsPathsInImage.java test to not load the entire file at once
• f8c6ad2: 8378727: [macOS] Missing dispatch_release for semaphores in CDesktopPeer
• ... and 34 more: https://git.openjdk.org/jdk25u-dev/compare/622fb19106ed6647807d910538a18a308f6c6cc4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@rm-gh-8 Pushed as commit f18c87f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.