Skip to content

8371187: [BigEndian Platforms] Vector lane reversal error#361

Open
offamitkumar wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-offamitkumar-ee2deade-master
Open

8371187: [BigEndian Platforms] Vector lane reversal error#361
offamitkumar wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-offamitkumar-ee2deade-master

Conversation

@offamitkumar
Copy link
Copy Markdown
Member

@offamitkumar offamitkumar commented Mar 10, 2026

Hi all,

This pull request contains a backport of commit ee2deade from the openjdk/jdk repository.

The commit being backported was authored by Varada M on 27 Jan 2026 and was reviewed by Martin Doerr and Amit Kumar.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • JDK-8371187 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8371187: [BigEndian Platforms] Vector lane reversal error (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/361/head:pull/361
$ git checkout pull/361

Update a local copy of the PR:
$ git checkout pull/361
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/361/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 361

View PR using the GUI difftool:
$ git pr show -t 361

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/361.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Mar 10, 2026

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 10, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport ee2deaded82e5fbd94aff7dd22cf2d5c57caa94e 8371187: [BigEndian Platforms] Vector lane reversal error Mar 10, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 10, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Mar 10, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 10, 2026

⚠️ @offamitkumar This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 10, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Mar 10, 2026

Webrevs

@offamitkumar
Copy link
Copy Markdown
Member Author

/approval The issue persists in JDK 25 LTS as well, so we have been requested to backport the changes.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 11, 2026

@offamitkumar usage: /approval [<id>] (request|cancel) [<text>]

@offamitkumar
Copy link
Copy Markdown
Member Author

/approval request The issue persists in JDK 25 LTS as well, so we have been requested to backport the changes.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 11, 2026

@offamitkumar
8371187: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Mar 11, 2026
@GoeLin
Copy link
Copy Markdown
Member

GoeLin commented Mar 12, 2026

HI @offamitkumar
can you please give a proper approval request comment?
List Reason/Risk/testing
"we have been requested" is not a proper reason.
Reason : Explain what is outstanding here that it should be backported while we omit lots of other bug fixes because we want to reduce the risk to break 25?
See also https://wiki.openjdk.org/spaces/JDKUpdates/pages/42598906/How+to+contribute+or+backport+a+fix
Especially part 6.

@GoeLin
Copy link
Copy Markdown
Member

GoeLin commented Mar 16, 2026

Hi @offamitkumar
Also, please backport to 26 first.
Removing the label in the meantime. Feel free to request approval again.
Thanks!

@openjdk openjdk bot removed the approval Requires approval; will be removed when approval is received label Mar 16, 2026
@offamitkumar
Copy link
Copy Markdown
Member Author

Hi @GoeLin,

will this reason be well enough:

This backport fixes the vector lane reversal error on big endian platform, where if vector operations are used then it will produce reversed vector lane output. More about this here: https://github.com/andreaTP/s390x-vector-bug-reproducer, Patch is clean and tier1 test are clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants