-
Notifications
You must be signed in to change notification settings - Fork 142
8354475: TestDockerMemoryMetricsSubgroup.java fails with exitValue = 1 #2282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8354475: TestDockerMemoryMetricsSubgroup.java fails with exitValue = 1 #2282
Conversation
👋 Welcome back schernyshev! A progress list of the required criteria for merging this PR into |
@sercher This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 11 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
/approval request Direct follow up for 8343191, that improves container detection. The fix skips the test in rootles setups. |
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout Backport-e579cca619147aa51563dc00f374e02db49e1238
git fetch https://git.openjdk.org/jdk21u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@sercher this pull request can not be integrated into git checkout Backport-e579cca619147aa51563dc00f374e02db49e1238
git fetch https://git.openjdk.org/jdk21u-dev.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
/integrate |
This is a clean backport of JDK-8354475, a follow up fix for JDK-8343191 (#2278)
This PR depends on and can be integrated after #2280
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2282/head:pull/2282
$ git checkout pull/2282
Update a local copy of the PR:
$ git checkout pull/2282
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2282/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2282
View PR using the GUI difftool:
$ git pr show -t 2282
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2282.diff
Using Webrev
Link to Webrev Comment