Skip to content

Conversation

rgithubli
Copy link
Contributor

@rgithubli rgithubli commented Sep 12, 2025

A clean backport for https://bugs.openjdk.org/browse/JDK-8357822.

Backport this for the parity with 21.0.10-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8357822 needs maintainer approval

Issue

  • JDK-8357822: C2: Multiple string optimization tests are no longer testing string concatenation optimizations (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2205/head:pull/2205
$ git checkout pull/2205

Update a local copy of the PR:
$ git checkout pull/2205
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2205/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2205

View PR using the GUI difftool:
$ git pr show -t 2205

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2205.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 12, 2025

👋 Welcome back rgithubli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 12, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 6c616c71ec9a8ee6e0203921deef20d09db39698 8357822: C2: Multiple string optimization tests are no longer testing string concatenation optimizations Sep 12, 2025
@openjdk
Copy link

openjdk bot commented Sep 12, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 12, 2025
@openjdk
Copy link

openjdk bot commented Sep 12, 2025

⚠️ @rgithubli This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 12, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 12, 2025

Webrevs

@rgithubli
Copy link
Contributor Author

/approval request A clean backport for https://bugs.openjdk.org/browse/JDK-8357822.

Backport this for the parity with 21.0.10-oracle.

@openjdk
Copy link

openjdk bot commented Sep 12, 2025

@rgithubli
8357822: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Sep 12, 2025
@GoeLin
Copy link
Member

GoeLin commented Sep 15, 2025

Hi @rgithubli
please run the tests and say so somewhere, best in the fix request comment.

@openjdk openjdk bot removed the approval Requires approval; will be removed when approval is received label Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants