Skip to content

8362582: GHA: Increase bundle retention time to deal with infra overload better #3781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jul 21, 2025

Improves GHA reliability.

Additional testing:

  • GHA

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8362582 needs maintainer approval

Issue

  • JDK-8362582: GHA: Increase bundle retention time to deal with infra overload better (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3781/head:pull/3781
$ git checkout pull/3781

Update a local copy of the PR:
$ git checkout pull/3781
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3781/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3781

View PR using the GUI difftool:
$ git pr show -t 3781

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3781.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 21, 2025

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 21, 2025

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362582: GHA: Increase bundle retention time to deal with infra overload better

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 1bd683b5884e65a03d564976a9d9220ad0893776 8362582: GHA: Increase bundle retention time to deal with infra overload better Jul 21, 2025
@openjdk
Copy link

openjdk bot commented Jul 21, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jul 21, 2025
@shipilev
Copy link
Member Author

/approval request Same reason as for 25u.

@openjdk
Copy link

openjdk bot commented Jul 21, 2025

@shipilev
8362582: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jul 21, 2025
@shipilev shipilev marked this pull request as ready for review July 21, 2025 17:57
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 21, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 21, 2025

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jul 22, 2025
@shipilev
Copy link
Member Author

Push approval granted. So I am integrating.

/integrate

@openjdk
Copy link

openjdk bot commented Jul 22, 2025

Going to push as commit eee7d9c.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 22, 2025
@openjdk openjdk bot closed this Jul 22, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 22, 2025
@openjdk
Copy link

openjdk bot commented Jul 22, 2025

@shipilev Pushed as commit eee7d9c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin
Copy link
Member

GoeLin commented Jul 22, 2025

Thanks again for this change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants