Skip to content

8341964: Add mechanism to disable different parts of TLS cipher suite #3775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jul 19, 2025

I backport this for parity with 17.0.17-oracle

I assume it was backportet there. There is a CSR for 17, and follow up JDK-8349583 was backported there.

src/java.base/share/classes/sun/security/util/DisabledAlgorithmConstraints.java
Resolved imports.

test/jdk/sun/security/ssl/CipherSuite/NoDesRC4DesEdeCiphSuite.java
This file was added by https://bugs.openjdk.org/browse/JDK-8163327 in 19. Omitted.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change requires CSR request JDK-8343623 to be approved
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8341964 needs maintainer approval

Issues

  • JDK-8341964: Add mechanism to disable different parts of TLS cipher suite (Enhancement - P3)
  • JDK-8343623: Add mechanism to disable different parts of TLS cipher suite (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3775/head:pull/3775
$ git checkout pull/3775

Update a local copy of the PR:
$ git checkout pull/3775
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3775/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3775

View PR using the GUI difftool:
$ git pr show -t 3775

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3775.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 19, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 19, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 697f27c5d53dbe275685b87c8ed1bcfe4da6e4d0 8341964: Add mechanism to disable different parts of TLS cipher suite Jul 19, 2025
@openjdk
Copy link

openjdk bot commented Jul 19, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jul 19, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 19, 2025

Webrevs

@MBaesken
Copy link
Member

Looks okay , but the non existing test has the name NoDesRC4CiphSuite in jdk17 (was moved to a new name NoDesRC4DesEdeCiphSuite in 19) ; have you checked for potential need of adjusting this test ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants