8381838: java/net/DatagramSocket/SendReceiveMaxSize.java fails to compile after JDK-8381008

[serhiysachkov]

java/net/DatagramSocket/SendReceiveMaxSize.java fails to compile due to merge issue

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8381838: java/net/DatagramSocket/SendReceiveMaxSize.java fails to compile after JDK-8381008 (Bug - P3)

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Jaikiran Pai (@jaikiran - Reviewer)
• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30624/head:pull/30624
$ git checkout pull/30624

Update a local copy of the PR:
$ git checkout pull/30624
$ git pull https://git.openjdk.org/jdk.git pull/30624/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30624

View PR using the GUI difftool:
$ git pr show -t 30624

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30624.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back serhiysachkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@serhiysachkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8381838: java/net/DatagramSocket/SendReceiveMaxSize.java fails to compile after JDK-8381008

Reviewed-by: ayang, jpai, dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• cc1c427: 8380755: jdk/jfr/event/gc/heapsummary/TestHeapSummaryEventG1.java fails gcId should be increasing

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@albertnetymk, @jaikiran, @dfuch) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@serhiysachkov The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (bf937d85)

[jaikiran]

Looks good and trivial to me.

The test would have failed compilation in #30548 itself, I'm guessing Matthias @MBaesken probably missed pushing an additional commit with this import.

[MBaesken]

Looks good and trivial to me.

The test would have failed compilation in #30548 itself, I'm guessing Matthias @MBaesken probably missed pushing an additional commit with this import.

In my PR I see a 'import jdk.test.lib.net.IPSupport;' on line 90 (and I had my PR in our internal build+test queue) ; really strange.

[MBaesken]

Seems 8380990 kicked out the needed import, so it was 'bad luck' .

[serhiysachkov]

Seems 8380990 kicked out the needed import, so it was 'bad luck' .

Yes, looks like both PRs came in today in the morning and GIT didn't find any merge issues, though there were some, seems to be bad timing and luck

[serhiysachkov]

/integrate

[openjdk]

@serhiysachkov
Your change (at version bf937d8) is now ready to be sponsored by a Committer.

[dfuch]

/sponsor

[openjdk]

Going to push as commit 988ec86.
Since your change was applied there has been 1 commit pushed to the master branch:

• cc1c427: 8380755: jdk/jfr/event/gc/heapsummary/TestHeapSummaryEventG1.java fails gcId should be increasing

Your commit was automatically rebased without conflicts.

[openjdk]

@dfuch @serhiysachkov Pushed as commit 988ec86.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.