8381616: Refactor various java/net/*Socket*/ TestNG tests to use JUnit

[dfuch]

Some more TestNG -> JUnit conversion for java/net tests.
This change converts tests under:

    test/jdk/java/net/DatagramSocketImpl/
    test/jdk/java/net/MulticastSocket/
    test/jdk/java/net/Socket/
    test/jdk/java/net/SocketImpl/

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8381616: Refactor various java/net/Socket/ TestNG tests to use JUnit (Sub-task - P4)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30564/head:pull/30564
$ git checkout pull/30564

Update a local copy of the PR:
$ git checkout pull/30564
$ git pull https://git.openjdk.org/jdk.git pull/30564/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30564

View PR using the GUI difftool:
$ git pr show -t 30564

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30564.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8381616: Refactor various java/net/*Socket*/ TestNG tests to use JUnit

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dfuch The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 11: Full (e9cd5bbc)
• 10: Full - Incremental (b90a6061)
• 09: Full - Incremental (37281c6a)
• 08: Full (cfa70f7e)
• 07: Full - Incremental (6ce49ad9)
• 06: Full - Incremental (799c5cbc)
• 05: Full - Incremental (734c7be6)
• 04: Full - Incremental (bcfbaa10)
• 03: Full - Incremental (f698fd19)
• 02: Full - Incremental (6f61029c)
• 01: Full - Incremental (339460f4)
• 00: Full (c5e7484f)

[Marcono1234]

Hopefully these comments are useful, if not please let me know. Again these are only suggestions; I am not an OpenJDK member, so feel free to ignore my comments.

[AlanBateman]

I skimmed through all the latest changes, only concern is the added comments to ConnectionReset.

[dfuch]

/integrate

[openjdk]

Going to push as commit 52a54da.

[openjdk]

@dfuch Pushed as commit 52a54da.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.